Skip to content

drm/ast: Convert to atomic modesetting

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 2 repliesIn review
  2. v19 patches 21 repliesSuperseded

Changes in v2 from the cover letter

* don't set plane call-back functions to NULL explicitly
* define plane format arrays in global scope

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/ast: Remove last traces of struct ast_gem_objectdrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c+0 -300 replies
2/9drm/ast: Check video-mode requirements against VRAM sizedrivers/gpu/drm/ast/ast_main.c+24 -10 replies
3/9drm/ast: Don't clear base address and offset with default valuesdrivers/gpu/drm/ast/ast_mode.c+6 -20 replies
4/9drm/ast: Split ast_set_ext_reg() into color and threshold functiondrivers/gpu/drm/ast/ast_mode.c+10 -50 replies
5/9drm/ast: Split ast_set_vbios_mode_info()drivers/gpu/drm/ast/ast_mode.c+72 -390 replies
6/9drm/ast: Add primary planedrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+89 -21 reply
7/9drm/ast: Add CRTC helpers for atomic modesettingdrivers/gpu/drm/ast/ast_mode.c+104 -10 replies
8/9drm/ast: Add cursor planedrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+155 -11 reply
9/9drm/ast: Enable atomic modesettingdrivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mode.c+33 -2860 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchGerd Hoffmann
1/9A-b
2/9A-b
3/9A-b
4/9A-b
5/9A-b
6/9A-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] drm/ast: Convert to atomic modesetting

This patch set adds universal planes to ast and converts the driver to atomic modesetting.

The first patch is purely for clean-up.

Patches 2 to 5 prepare the ast modesetting code for universal planes and atomic modesetting. The size calculation for each mode has to take double buffering into account. Several functions have to be split to make them work with the separate check and update on CRTCs and planes. There are no functional changes.

Patches 6 to 8 add atomic modesetting code for planes and CRTC. Planes immediately provide atomic functions. There's no intermediate step with legacy functions for non-atomic drivers. The cursor plane HW only supports ARGB4444, so the cursor plane converts the format internally; just as the legacy implementation did.

Finally, patch 9 adds missing helpers and enables atomic modesetting. The CRTC functions now provide page_flip, which enables Weston support on ast hardware.

The patchset has been tested by running the fbdev console, X11 (Gnome) and Weston on an AST2100 chipset.

v2:
* don't set plane call-back functions to NULL explicitly
* define plane format arrays in global scope

Thomas Zimmermann (9):
drm/ast: Remove last traces of struct ast_gem_object drm/ast: Check video-mode requirements against VRAM size drm/ast: Don't clear base address and offset with default values drm/ast: Split ast_set_ext_reg() into color and threshold function drm/ast: Split ast_set_vbios_mode_info()
drm/ast: Add primary plane
drm/ast: Add CRTC helpers for atomic modesetting drm/ast: Add cursor plane
drm/ast: Enable atomic modesetting

 drivers/gpu/drm/ast/ast_drv.c  |  24 +-
 drivers/gpu/drm/ast/ast_drv.h  |   9 +-
 drivers/gpu/drm/ast/ast_main.c |  54 +--
 drivers/gpu/drm/ast/ast_mode.c | 685 ++++++++++++++++++++-------------
 4 files changed, 449 insertions(+), 323 deletions(-)

--
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel