Skip to content

Improvements for random.h/archrandom.h

Richard Henderson linux-arch linux-arm-kernel linux-crypto linux-s390 linuxppc-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 1 replyIn review
  2. v16 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* Remove arch_has_random, arch_has_random_seed.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10x86: Remove arch_has_random, arch_has_random_seedarch/x86/include/asm/archrandom.h+4 -80 replies
2/10powerpc: Remove arch_has_random, arch_has_random_seedarch/powerpc/include/asm/archrandom.h+0 -100 replies
3/10s390: Remove arch_has_random, arch_has_random_seedarch/s390/include/asm/archrandom.h+0 -120 replies
4/10linux/random.h: Remove arch_has_random, arch_has_random_seedinclude/linux/random.h+0 -80 replies
5/10linux/random.h: Use false with boolinclude/linux/random.h+4 -40 replies
6/10linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_checkinclude/linux/random.h+4 -40 replies
7/10x86: Mark archrandom.h functions __must_checkarch/x86/include/asm/archrandom.h+8 -80 replies
8/10powerpc: Use bool in archrandom.harch/powerpc/include/asm/archrandom.h+9 -80 replies
9/10powerpc: Mark archrandom.h functions __must_checkarch/powerpc/include/asm/archrandom.h+4 -40 replies
10/10s390x: Mark archrandom.h functions __must_checkarch/s390/include/asm/archrandom.h+4 -40 replies

Reviews trailers per patch

5 of 10 patches have a Reviewed-by or Acked-by.

PatchArd BiesheuvelMichael EllermanHarald Freudenberger
1/10
2/10
3/10
4/10
5/10
6/10R-b
7/10R-b
8/10R-b
9/10R-b A-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/10] Improvements for random.h/archrandom.h

During patch review for an addition of archrandom.h for arm64, it was suggeted that the arch_random_get_* functions should be marked __must_check. Which does sound like a good idea, since the by-reference integer output may be uninitialized when the boolean result is false.

In addition, it turns out that arch_has_random() and arch_has_random_seed() are not used, and not easy to support for arm64. Rather than cobble something together that would not be testable, remove the interfaces against some future accidental use.

In addition, I noticed a few other minor inconsistencies between the different architectures, e.g. powerpc isn't using bool.

Change since v1:
* Remove arch_has_random, arch_has_random_seed.

r~

Richard Henderson (10):
x86: Remove arch_has_random, arch_has_random_seed
powerpc: Remove arch_has_random, arch_has_random_seed
s390: Remove arch_has_random, arch_has_random_seed linux/random.h: Remove arch_has_random, arch_has_random_seed linux/random.h: Use false with bool
linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
x86: Mark archrandom.h functions __must_check
powerpc: Use bool in archrandom.h
powerpc: Mark archrandom.h functions __must_check
s390x: Mark archrandom.h functions __must_check

 arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
 arch/s390/include/asm/archrandom.h    | 20 ++++---------------
 arch/x86/include/asm/archrandom.h     | 28 ++++++++++++---------------
 include/linux/random.h                | 24 ++++++++---------------
 4 files changed, 33 insertions(+), 66 deletions(-)
Signature · 1 line
2.17.1