Improvements for random.h/archrandom.h
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 1 replyIn review
- v16 patches 6 repliesSuperseded
Changes in v2 from the cover letter
* Remove arch_has_random, arch_has_random_seed.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | x86: Remove arch_has_random, arch_has_random_seedarch/ | +4 | 0 replies | |
| 2/10 | powerpc: Remove arch_has_random, arch_has_random_seedarch/ | +0 | 0 replies | |
| 3/10 | s390: Remove arch_has_random, arch_has_random_seedarch/ | +0 | 0 replies | |
| 4/10 | linux/random.h: Remove arch_has_random, arch_has_random_seedinclude/ | +0 | 0 replies | |
| 5/10 | linux/random.h: Use false with boolinclude/ | +4 | 0 replies | |
| 6/10 | linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_checkinclude/ | +4 | 0 replies | |
| 7/10 | x86: Mark archrandom.h functions __must_checkarch/ | +8 | 0 replies | |
| 8/10 | powerpc: Use bool in archrandom.harch/ | +9 | 0 replies | |
| 9/10 | powerpc: Mark archrandom.h functions __must_checkarch/ | +4 | 0 replies | |
| 10/10 | s390x: Mark archrandom.h functions __must_checkarch/ | +4 | 0 replies |
Reviews trailers per patch
5 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Ard Biesheuvel | Michael Ellerman | Harald Freudenberger |
|---|---|---|---|
| 1/10 | |||
| 2/10 | |||
| 3/10 | |||
| 4/10 | |||
| 5/10 | |||
| 6/10 | R-b | ||
| 7/10 | R-b | ||
| 8/10 | R-b | ||
| 9/10 | R-b | A-b | |
| 10/10 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/10] Improvements for random.h/archrandom.h
During patch review for an addition of archrandom.h for arm64, it was suggeted that the arch_random_get_* functions should be marked __must_check. Which does sound like a good idea, since the by-reference integer output may be uninitialized when the boolean result is false.
In addition, it turns out that arch_has_random() and arch_has_random_seed() are not used, and not easy to support for arm64. Rather than cobble something together that would not be testable, remove the interfaces against some future accidental use.
In addition, I noticed a few other minor inconsistencies between the different architectures, e.g. powerpc isn't using bool.
Change since v1:
* Remove arch_has_random, arch_has_random_seed.
r~
Richard Henderson (10):
x86: Remove arch_has_random, arch_has_random_seed
powerpc: Remove arch_has_random, arch_has_random_seed
s390: Remove arch_has_random, arch_has_random_seed linux/random.h: Remove arch_has_random, arch_has_random_seed linux/random.h: Use false with bool
linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
x86: Mark archrandom.h functions __must_check
powerpc: Use bool in archrandom.h
powerpc: Mark archrandom.h functions __must_check
s390x: Mark archrandom.h functions __must_check
arch/powerpc/include/asm/archrandom.h | 27 +++++++++----------------- arch/s390/include/asm/archrandom.h | 20 ++++--------------- arch/x86/include/asm/archrandom.h | 28 ++++++++++++--------------- include/linux/random.h | 24 ++++++++--------------- 4 files changed, 33 insertions(+), 66 deletions(-)
Signature · 1 line
2.17.1