RFC powerpc: make iowrite32be etc. inline
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | asm-generic: move pcu_iounmap from iomap.h to pci_iomap.hinclude/ include/ | +7 | 0 replies | |
| 2/5 | asm-generic: employ "ifndef foo; define foo foo" idiom in iomap.hinclude/ | +88 | 0 replies | |
| 3/5 | powerpc: move pci_iounmap() from iomap.c to pci-common.carch/ arch/ | +13 | 0 replies | |
| 4/5 | powerpc: make pcibios_vaddr_is_ioport() staticarch/ arch/ | +2 | 0 replies | |
| 5/5 | powerpc: make iowrite32 and friends static inline when no indirectionarch/ arch/ | +173 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/5] powerpc: make iowrite32be etc. inline
When trying to make the QUICC Engine drivers compile on arm, I mechanically (with coccinelle) changed out_be32() to iowrite32be() etc. Christophe pointed out [1][2] that that would pessimize the powerpc SOCs since the IO accesses now incur a function call overhead. He asked that I try to make those io accessors inline on ppc, and this is the best I could come up with.
At first I tried something that wouldn't need to touch anything outside arch/powerpc/, but I ended up with conditional inclusion of asm-generic headers and/or duplicating a lot of their contents.
The diffstat may become a little better if kernel/iomap.c can indeed be removed (due to !CONFIG_PPC_INDIRECT_PIO && CONFIG_PPC_INDIRECT_MMIO never happening).
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
Rasmus Villemoes (5):
asm-generic: move pcu_iounmap from iomap.h to pci_iomap.h
asm-generic: employ "ifndef foo; define foo foo" idiom in iomap.h
powerpc: move pci_iounmap() from iomap.c to pci-common.c
powerpc: make pcibios_vaddr_is_ioport() static
powerpc: make iowrite32 and friends static inline when no indirection
arch/powerpc/include/asm/io.h | 172 ++++++++++++++++++++++++++ arch/powerpc/include/asm/pci-bridge.h | 9 -- arch/powerpc/kernel/Makefile | 2 +- arch/powerpc/kernel/iomap.c | 13 -- arch/powerpc/kernel/pci-common.c | 15 ++- include/asm-generic/iomap.h | 104 +++++++++++++--- include/asm-generic/pci_iomap.h | 7 ++ 7 files changed, 282 insertions(+), 40 deletions(-)
Signature · 1 line
2.23.0