Skip to content

ufs: Rework tag allocation

Bart Van Assche linux-scsi 7 versions – Applied

Status from this message: Applied to 5.6/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 1 replyApplied
  2. v64 patches 9 repliesSuperseded
  3. v54 patches 13 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v43 patches6 repliesSuperseded
v3 RFC3 patches4 repliesSuperseded
v2 RFC5 patches8 repliesSuperseded
v14 patches2 repliesSuperseded

Changes in v7 from the cover letter

- Reduced this patch series to include only those patches that received positive reviews.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2ufs: Avoid busy-waiting by eliminating tag conflictsdrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+50 -770 replies
2/2ufs: Use blk_{get,put}_request() to allocate and free TMFsdrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+80 -620 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBean HuoAvri Altman
1/2T-b R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] ufs: Rework tag allocation

Hi Martin,

This patch series simplifies and optimizes the UFS driver. Please consider this patch series for kernel v5.6.

Thanks,

Bart.

Changes compared to v6:
- Reduced this patch series to include only those patches that received positive reviews.

Changes compared to v5:
- Reworked patch 4/4 such that it only modifies the clock scaling code and no other code. Added more comments in the code and improved the patch description.
- Rebased this patch series on top of the 5.5/scsi-queue branch.

Changes compared to v4:
- Reverted back to scsi_block_requests() / scsi_unblock_requests() for the UFS error handler.
- Added a new patch that serializes error handling and command submission.
- Fixed a blk_mq_init_queue() return value check.

Changes compared to v3:
- Left out "scsi" from the name of the functions that suspend and resume command processing.

Changes compared to v2:
- Use a separate tag set for TMF tags.

Changes compared to v1:
- Use the block layer tag infrastructure for managing TMF tags. Bart Van Assche (2):
ufs: Avoid busy-waiting by eliminating tag conflicts
ufs: Use blk_{get,put}_request() to allocate and free TMFs

 drivers/scsi/ufs/ufshcd.c | 249 +++++++++++++++++++-------------------
 drivers/scsi/ufs/ufshcd.h |  18 +--
 2 files changed, 129 insertions(+), 138 deletions(-)