Skip to content

icmp: move duplicate code in helper functions

Matteo Croce lkml netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2icmp: add helpers to recognize ICMP error packetsinclude/linux/icmp.h include/linux/icmpv6.h+29 -00 replies
2/2icmp: remove duplicate codenet/ipv4/netfilter/nf_socket_ipv4.c net/ipv4/route.c net/ipv6/route.c +3 more+6 -300 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] icmp: move duplicate code in helper functions

Remove some duplicate code by moving it in two helper functions. First patch adds the helpers, the second one uses it.

Matteo Croce (2):
icmp: add helpers to recognize ICMP error packets
icmp: remove duplicate code

 include/linux/icmp.h                    | 15 +++++++++++++++
 include/linux/icmpv6.h                  | 14 ++++++++++++++
 net/ipv4/netfilter/nf_socket_ipv4.c     | 10 +---------
 net/ipv4/route.c                        |  5 +----
 net/ipv6/route.c                        |  5 +----
 net/netfilter/nf_conntrack_proto_icmp.c |  6 +-----
 net/netfilter/xt_HMARK.c                |  6 +-----
 net/sched/act_nat.c                     |  4 +---
 8 files changed, 35 insertions(+), 30 deletions(-)
Signature · 1 line
2.23.0