mlxsw: Add extended ACK for EMADs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 2 repliesIn review
- v16 patches 13 repliesSuperseded
Changes in v2 from the cover letter
* Use existing devlink hwerr tracepoint to report the error string, instead of printing it to kernel log
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mlxsw: core: Parse TLVs' offsets of incoming EMADsdrivers/ | +42 | 0 replies | |
| 2/7 | mlxsw: emad: Remove deprecated EMAD TLVsdrivers/ | +1 | 0 replies | |
| 3/7 | mlxsw: core: Add EMAD string TLVdrivers/ drivers/ | +24 | 0 replies | |
| 4/7 | mlxsw: core: Add support for EMAD string TLV parsingdrivers/ | +15 | 0 replies | |
| 5/7 | mlxsw: core: Extend EMAD information reported to devlink hwerrdrivers/ | +10 | 0 replies | |
| 6/7 | mlxsw: core: Add support for using EMAD string TLVdrivers/ drivers/ | +72 | 0 replies | |
| 7/7 | mlxsw: spectrum: Enable EMAD string TLVdrivers/ | +2 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Pirko |
|---|---|
| 1/7 | A-b |
| 2/7 | A-b |
| 3/7 | A-b |
| 4/7 | A-b |
| 5/7 | A-b |
| 6/7 | A-b |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/7] mlxsw: Add extended ACK for EMADs
From: Ido Schimmel <[email protected]>
Shalom says:
Ethernet Management Datagrams (EMADs) are Ethernet packets sent between the driver and device's firmware. They are used to pass various configurations to the device, but also to get events (e.g., port up) from it. After the Ethernet header, these packets are built in a TLV format.
Up until now, whenever the driver issued an erroneous register access it only got an error code indicating a bad parameter was used. This patch set adds a new TLV (string TLV) that can be used by the firmware to encode a 128 character string describing the error. The new TLV is allocated by the driver and set to zeros. In case of error, the driver will check the length of the string in the response and report it using devlink hwerr tracepoint.
Example:
$ perf record -a -q -e devlink:devlink_hwerr &
$ pkill -2 perf
$ perf script -F trace:event,trace | grep hwerr devlink:devlink_hwerr: bus_name=pci dev_name=0000:03:00.0 driver_name=mlxsw_spectrum err=7 (tid=9913892d00001593,reg_id=8018(rauhtd)) bad parameter (inside er_rauhtd_write_query(), num_rec=32 is over the maximum number of records supported)
Patch #1 parses the offsets of the different TLVs in incoming EMADs and stores them in the skb's control block. This makes it easier to later add new TLVs.
Patches #2-#3 remove deprecated TLVs and add string TLV definition.
Patches #4-#7 gradually add support for the new string TLV.
v2:
* Use existing devlink hwerr tracepoint to report the error string, instead of printing it to kernel log
Shalom Toledo (7):
mlxsw: core: Parse TLVs' offsets of incoming EMADs
mlxsw: emad: Remove deprecated EMAD TLVs
mlxsw: core: Add EMAD string TLV
mlxsw: core: Add support for EMAD string TLV parsing
mlxsw: core: Extend EMAD information reported to devlink hwerr
mlxsw: core: Add support for using EMAD string TLV
mlxsw: spectrum: Enable EMAD string TLV
drivers/net/ethernet/mellanox/mlxsw/core.c | 171 ++++++++++++++++-- drivers/net/ethernet/mellanox/mlxsw/core.h | 2 + drivers/net/ethernet/mellanox/mlxsw/emad.h | 7 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 2 + 4 files changed, 162 insertions(+), 20 deletions(-)
Signature · 1 line
2.21.0