gpiolib: fix GPIO <-> pin mapping registration
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest7 patches 17 repliesIn review
Changes in v2 from the cover letter
- fixed cover letter
- resent with ML included
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | gpiolib: Switch order of valid mask and hw initdrivers/ | +2 | 0 replies | |
| 2/7 | gpiolib: No need to call gpiochip_remove_pin_ranges() twicedrivers/ drivers/ | +3 | 0 replies | |
| 3/7 | gpiolib: Introduce ->add_pin_ranges() callbackdrivers/ include/ | +17 | 5 replies | |
| 4/7 | gpio: merrifield: Add GPIO <-> pin mapping ranges via callbackdrivers/ | +26 | 2 replies | |
| 5/7 | gpio: merrifield: Pass irqchip when adding gpiochipdrivers/ | +20 | 1 reply | |
| 6/7 | pinctrl: baytrail: Add GPIO <-> pin mapping ranges via callbackdrivers/ | +14 | 1 reply | |
| 7/7 | pinctrl: baytrail: Pass irqchip when adding gpiochipdrivers/ | +25 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Hans de Goede | Andy Shevchenko | Mika Westerberg | Linus Walleij |
|---|---|---|---|---|
| Series | T-b R-b | |||
| 1/7 | A-b | R-b | R-b | |
| 2/7 | ||||
| 3/7 | R-b | R-b | ||
| 4/7 | R-b | |||
| 5/7 | R-b | |||
| 6/7 | R-b | |||
| 7/7 | A-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration
This is the ordering fix for GPIO <-> pin mapping registration to allow delegation of IRQ chip to the GPIO library. Two drivers are actually converted to use the new callback followed by switching to use of irqchip structure inside gpiochip.
The series has been tested on Merrifield device (though no AEI) and on Thinkpad 10 where 4 events are registered, one of which has reasonable amount of interrupts coming from battery.
First two patches are definitely good for v5.4 cycle (and have Fixes tag) while the rest can be applied for v5.5 if I didn't miss anything. So, they can go like patches 1-3 -> v5.4 (gpio/fixes) and to gpio/for-next and to pinctrl/for-next patches 4-5 -> v5.5 (gpio/for-next)
patches 6-7 -> v5.5 (pinctrl/for-next)
Perhaps it would require to wait next v5.4 rc in order to avoid dependency issues.
Changelog v2 (resent):
- fixed cover letter
- resent with ML included
Changelog v2:
- added fixes tag to the first patch
- reworked commit message for the second patch
- added baytrail conversion
- tested on ThinkPad 10
Andy Shevchenko (6):
gpiolib: No need to call gpiochip_remove_pin_ranges() twice
gpiolib: Introduce ->add_pin_ranges() callback
gpio: merrifield: Add GPIO <-> pin mapping ranges via callback
gpio: merrifield: Pass irqchip when adding gpiochip
pinctrl: baytrail: Add GPIO <-> pin mapping ranges via callback
pinctrl: baytrail: Pass irqchip when adding gpiochip
Linus Walleij (1):
gpiolib: Switch order of valid mask and hw init
drivers/gpio/gpio-merrifield.c | 76 ++++++++++++++---------- drivers/gpio/gpiolib-of.c | 5 +- drivers/gpio/gpiolib.c | 19 +++++- drivers/pinctrl/intel/pinctrl-baytrail.c | 64 ++++++++++++-------- include/linux/gpio/driver.h | 5 ++ 5 files changed, 107 insertions(+), 62 deletions(-)
Signature · 1 line
2.24.0.rc1