Skip to content

pinctrl: intel: Move Lynxpoint to pin control umbrella

Andy Shevchenko linux-gpio oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest24 patches 6 repliesIn review
  2. v18 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- fixed ordering in Kconfig and Makefile (Mika)
- finished conversion to pin control

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24pinctrl: lynxpoint: Move GPIO driver to pin controller folderMAINTAINERS drivers/gpio/Kconfig drivers/gpio/Makefile +3 more+11 -100 replies
2/24pinctrl: lynxpoint: Use raw_spinlock for lockingdrivers/pinctrl/intel/pinctrl-lynxpoint.c+14 -140 replies
3/24pinctrl: lynxpoint: Correct amount of pinsdrivers/pinctrl/intel/pinctrl-lynxpoint.c+6 -60 replies
4/24pinctrl: lynxpoint: Drop useless assignmentdrivers/pinctrl/intel/pinctrl-lynxpoint.c+1 -10 replies
5/24pinctrl: lynxpoint: Use %pR to print IO resourcedrivers/pinctrl/intel/pinctrl-lynxpoint.c+1 -20 replies
6/24pinctrl: lynxpoint: Use standard pattern for memory allocationdrivers/pinctrl/intel/pinctrl-lynxpoint.c+1 -10 replies
7/24pinctrl: lynxpoint: Assume 2 bits for mode selectordrivers/pinctrl/intel/pinctrl-lynxpoint.c+4 -20 replies
8/24pinctrl: lynxpoint: Relax GPIO request rulesdrivers/pinctrl/intel/pinctrl-lynxpoint.c+11 -30 replies
9/24pinctrl: lynxpoint: Keep pointer to struct device instead of its containerdrivers/pinctrl/intel/pinctrl-lynxpoint.c+7 -70 replies
10/24pinctrl: lynxpoint: Switch to memory mapped IO accessorsdrivers/pinctrl/intel/pinctrl-lynxpoint.c+44 -440 replies
11/24pinctrl: lynxpoint: Convert unsigned to unsigned intdrivers/pinctrl/intel/pinctrl-lynxpoint.c+12 -120 replies
12/24pinctrl: lynxpoint: Extract lp_gpio_acpi_use() for future usedrivers/pinctrl/intel/pinctrl-lynxpoint.c+12 -20 replies
13/24pinctrl: lynxpoint: Move ->remove closer to ->probe()drivers/pinctrl/intel/pinctrl-lynxpoint.c+6 -60 replies
14/24pinctrl: lynxpoint: Move lp_irq_type() closer to IRQ related routinesdrivers/pinctrl/intel/pinctrl-lynxpoint.c+44 -440 replies
15/24pinctrl: lynxpoint: Move ownership check to IRQ chipdrivers/pinctrl/intel/pinctrl-lynxpoint.c+6 -60 replies
16/24pinctrl: lynxpoint: Implement ->irq_ack() callbackdrivers/pinctrl/intel/pinctrl-lynxpoint.c+14 -30 replies
17/24pinctrl: lynxpoint: Implement intel_gpio_get_direction callbackdrivers/pinctrl/intel/pinctrl-lynxpoint.c+11 -00 replies
18/24pinctrl: lynxpoint: Add pin control data structuresdrivers/pinctrl/intel/pinctrl-lynxpoint.c+124 -20 replies
19/24pinctrl: lynxpoint: Reuse struct intel_pinctrl in the driverdrivers/pinctrl/intel/pinctrl-lynxpoint.c+60 -242 replies
20/24pinctrl: lynxpoint: Add pin control operationsdrivers/pinctrl/intel/pinctrl-lynxpoint.c+314 -10 replies
21/24pinctrl: lynxpoint: Implement ->pin_dbg_show()drivers/pinctrl/intel/pinctrl-lynxpoint.c+23 -00 replies
22/24pinctrl: lynxpoint: Add GPIO <-> pin mapping ranges via callbackdrivers/pinctrl/intel/pinctrl-lynxpoint.c+14 -00 replies
23/24pinctrl: lynxpoint: Switch to pin control APIdrivers/pinctrl/intel/Kconfig drivers/pinctrl/intel/pinctrl-lynxpoint.c+13 -570 replies
24/24pinctrl: lynxpoint: Update summary in the driverdrivers/pinctrl/intel/pinctrl-lynxpoint.c+6 -40 replies

Reviews trailers per patch

None of the 24 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMika WesterbergLinus Walleij
SeriesA-b R-b
1/24
2/24
3/24
4/24
5/24
6/24
7/24
8/24
9/24
10/24
11/24
12/24
13/24
14/24
15/24
16/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/24] pinctrl: intel: Move Lynxpoint to pin control umbrella

Intel Lynxpoint GPIO is actually half way to the Chassis specification that has been established starting from Intel Skylake. It has some pin control properties we may utilize. To achieve this, move the driver under pin control umbrella and do a bunch of clean ups.

The series has been tested on Broadwell Ultrabook where Lynxpoint GPIO is exposed to the OS.

It has a dependency to patches in my review branch [1]. That dependency patch is supposed to be submitted soon as a part of Baytrail clean up. In the mentioned branch the patches are represented in the correct order.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git/log/?h=review-andy

Changes v2:
- fixed ordering in Kconfig and Makefile (Mika)
- finished conversion to pin control

Andy Shevchenko (24):
pinctrl: lynxpoint: Move GPIO driver to pin controller folder
pinctrl: lynxpoint: Use raw_spinlock for locking
pinctrl: lynxpoint: Correct amount of pins
pinctrl: lynxpoint: Drop useless assignment
pinctrl: lynxpoint: Use %pR to print IO resource
pinctrl: lynxpoint: Use standard pattern for memory allocation
pinctrl: lynxpoint: Assume 2 bits for mode selector
pinctrl: lynxpoint: Relax GPIO request rules
pinctrl: lynxpoint: Keep pointer to struct device instead of its
container
pinctrl: lynxpoint: Switch to memory mapped IO accessors
pinctrl: lynxpoint: Convert unsigned to unsigned int
pinctrl: lynxpoint: Extract lp_gpio_acpi_use() for future use
pinctrl: lynxpoint: Move ->remove closer to ->probe()
pinctrl: lynxpoint: Move lp_irq_type() closer to IRQ related routines
pinctrl: lynxpoint: Move ownership check to IRQ chip
pinctrl: lynxpoint: Implement ->irq_ack() callback
pinctrl: lynxpoint: Implement intel_gpio_get_direction callback
pinctrl: lynxpoint: Add pin control data structures
pinctrl: lynxpoint: Reuse struct intel_pinctrl in the driver
pinctrl: lynxpoint: Add pin control operations
pinctrl: lynxpoint: Implement ->pin_dbg_show()
pinctrl: lynxpoint: Add GPIO <-> pin mapping ranges via callback
pinctrl: lynxpoint: Switch to pin control API
pinctrl: lynxpoint: Update summary in the driver

 MAINTAINERS                               |   1 -
 drivers/gpio/Kconfig                      |   8 -
 drivers/gpio/Makefile                     |   1 -
 drivers/gpio/gpio-lynxpoint.c             | 471 -----------
 drivers/pinctrl/intel/Kconfig             |  13 +
 drivers/pinctrl/intel/Makefile            |   1 +
 drivers/pinctrl/intel/pinctrl-lynxpoint.c | 975 ++++++++++++++++++++++
 7 files changed, 989 insertions(+), 481 deletions(-)
 delete mode 100644 drivers/gpio/gpio-lynxpoint.c
 create mode 100644 drivers/pinctrl/intel/pinctrl-lynxpoint.c
Signature · 1 line
2.24.0