Skip to content

Add support for Layerscape external interrupt lines

Rasmus Villemoes linux-devicetree lkml 1 version Applied

Status from this message: Applied to irqchip-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v7 Latest2 patches 5 repliesApplied

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2dt/bindings: Add bindings for Layerscape external irqsDocumentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt+49 -00 replies
2/2irqchip: add support for Layerscape external interrupt linesdrivers/irqchip/Kconfig drivers/irqchip/Makefile drivers/irqchip/irq-ls-extirq.c+202 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchVladimir Oltean
SeriesT-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] Add support for Layerscape external interrupt lines

In v7, I've tried to change from a custom binding to use interrupt-map, modelled on the recent addition of the renesas,rza1-irqc (commits a644ccb819bc and 5e27a314a11f). It's possible that the interrupt-map parsing code can be factored to a common helper, but it's a bit hard to generalize from two examples to know what a good interface would look like.

The interrupt-map-mask is a bit arbitrary. 0xff would likely work just as well (but I think the ls2088a has 32 external lines, so it has to be a least 0x1f).

Also, this drops the fsl,bit-reverse property and instead reads the SCFGREVCR register to determine if bit-reversing is needed.

The dt/bindings patch now comes first in accordance with Documentation/devicetree/bindings/submitting-patches.txt.

Earlier versions can be found here:

v6: https://lore.kernel.org/lkml/[email protected]/
v5: https://lore.kernel.org/lkml/[email protected]/

Rasmus Villemoes (2):
dt/bindings: Add bindings for Layerscape external irqs
irqchip: add support for Layerscape external interrupt lines

 .../interrupt-controller/fsl,ls-extirq.txt    |  49 +++++
 drivers/irqchip/Kconfig                       |   4 +
 drivers/irqchip/Makefile                      |   1 +
 drivers/irqchip/irq-ls-extirq.c               | 197 ++++++++++++++++++
 4 files changed, 251 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt
 create mode 100644 drivers/irqchip/irq-ls-extirq.c
Signature · 1 line
2.23.0