Skip to content

USB: serial: mos7840: type detection and clean ups

Johan Hovold linux-usb 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11USB: serial: mos7840: clean up device-type handlingdrivers/usb/serial/mos7840.c+44 -770 replies
2/11USB: serial: mos7840: document MCS7810 detection hackdrivers/usb/serial/mos7840.c+7 -00 replies
3/11USB: serial: mos7840: fix probe error handlingdrivers/usb/serial/mos7840.c+28 -200 replies
4/11USB: serial: mos7840: rip out broken interrupt handlingdrivers/usb/serial/mos7840.c+3 -2910 replies
5/11USB: serial: mos7840: drop redundant urb context checkdrivers/usb/serial/mos7840.c+1 -50 replies
6/11USB: serial: mos7840: drop paranoid port checksdrivers/usb/serial/mos7840.c+8 -840 replies
7/11USB: serial: mos7840: drop paranoid serial checksdrivers/usb/serial/mos7840.c+2 -360 replies
8/11USB: serial: mos7840: drop serial struct accessordrivers/usb/serial/mos7840.c+0 -300 replies
9/11USB: serial: mos7840: drop port driver data accessorsdrivers/usb/serial/mos7840.c+13 -910 replies
10/11USB: serial: mos7840: drop read-urb checkdrivers/usb/serial/mos7840.c+0 -110 replies
11/11USB: serial: mos7840: drop port open flagdrivers/usb/serial/mos7840.c+1 -280 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-Hartman
SeriesR-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] USB: serial: mos7840: type detection and clean ups

The mos7840 device-type detection is fragile and cannot generally be relied upon (e.g. as recently reported for Moxa UPort 2210 which was detected as a four-port device).

The first couple of patches adds support for encoding known chip features in the device-id table, and documents the underlying assumptions for the mcs7810-detection hack.

Turns out we have a lot of legacy cruft in this driver, and the remaining patches rips that out.

Johan

Johan Hovold (11):
USB: serial: mos7840: clean up device-type handling
USB: serial: mos7840: document MCS7810 detection hack
USB: serial: mos7840: fix probe error handling
USB: serial: mos7840: rip out broken interrupt handling
USB: serial: mos7840: drop redundant urb context check
USB: serial: mos7840: drop paranoid port checks
USB: serial: mos7840: drop paranoid serial checks
USB: serial: mos7840: drop serial struct accessor
USB: serial: mos7840: drop port driver data accessors
USB: serial: mos7840: drop read-urb check
USB: serial: mos7840: drop port open flag

 drivers/usb/serial/mos7840.c | 770 +++++------------------------------
 1 file changed, 102 insertions(+), 668 deletions(-)
Signature · 1 line
2.23.0