Skip to content

nvme-pci: check CQ after batch submission for Microsoft device

Ming Lei linux-nvme 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 13 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v12 patches 25 repliesSuperseded

Changes in v3 from the cover letter

- replace spin_trylock_irqsave with spin_trylock_irq
- fix comment on cq_lock & cq_poll_lock

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nvme-pci: move sq/cq_poll lock initialization into nvme_init_queuedrivers/nvme/host/pci.c+3 -20 replies
2/2nvme-pci: check CQ after batch submission for Microsoft devicedrivers/nvme/host/nvme.h drivers/nvme/host/pci.c+88 -132 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 0/2] nvme-pci: check CQ after batch submission for Microsoft device

Hi,

The two patches fix one performance regression on Microsoft Corporation device. The root cause is that Microsoft device applies aggressive interrupt coalescing, so single job fio performance drops much after we removes checking cq in f9dde187fa92("nvme-pci: remove cq check after submission").

Turns out this issue is very specific on Microsoft device, so add a quirk for checking CQ on this device.

V3:
- replace spin_trylock_irqsave with spin_trylock_irq
- fix comment on cq_lock & cq_poll_lock

V2:
- only check CQ for Microsoft device.

Ming Lei (2):
nvme-pci: move sq/cq_poll lock initialization into nvme_init_queue
nvme-pci: check CQ after batch submission for Microsoft device

 drivers/nvme/host/nvme.h |  6 +++
 drivers/nvme/host/pci.c  | 98 ++++++++++++++++++++++++++++++++++------
 2 files changed, 90 insertions(+), 14 deletions(-)
Cc Keith Busch <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Sagi Grimberg <[email protected]>
Cc Long Li <[email protected]>
Signature · 7 lines
2.20.1


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme