Skip to content

s390x/cpumodel: Introduce dynamic feature group

David Hildenbrand qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 10 repliesIn review
  2. v12 patches 23 repliesSuperseded

Changes in v2 from the cover letter

- Use dynamic feature groups instead of new models

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg07222.html

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2s390x/cpumodel: Factor out CPU feature dependenciestarget/s390x/cpu_models.c+58 -570 replies
2/2s390x/cpumodel: Introduce dynamic feature groupstarget/s390x/cpu_features.c target/s390x/cpu_features.h target/s390x/cpu_models.c+170 -010 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group

This thread was previously called:

    s390x/cpumodel: Introduce "best" model variants

There was recently a discussion regarding CPU model versions. That concept does not fit s390x where we have a lot of feature variability. I proposed an alternative approach in [1], which might work for x86 as well (but I am not sure if x86 still can or wants to switch to that), and requires only little changes in upper layers.

[1] and patch #2 contains more information on the motivation for this. It allows, for example, to specify/expand "best feature set possible on this accelerator, hw and, firmware"

"
Get the best possible feature set (e.g., excluding deprecated features) for a CPU definition in the configuration
-cpu z14,all-features=off,recommended-features=on

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Get all valid features for a CPU definition:
-cpu z14,all-features=on
"

v1 -> v2:
- Use dynamic feature groups instead of new models

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg07222.html

Cc Daniel P. Berrangé <[email protected]>
Cc Markus Armbruster <[email protected]>
Cc Jiri Denemark <[email protected]>
Cc Eduardo Habkost <[email protected]>
Cc Michael Mueller <[email protected]>
Cc Peter Maydell <[email protected]>

David Hildenbrand (2):
s390x/cpumodel: Factor out CPU feature dependencies s390x/cpumodel: Introduce dynamic feature groups

 target/s390x/cpu_features.c |  29 +++++
 target/s390x/cpu_features.h |  14 +++
 target/s390x/cpu_models.c   | 242 +++++++++++++++++++++++++++---------
 3 files changed, 228 insertions(+), 57 deletions(-)
Signature · 1 line
2.21.0