Skip to content

iotests: Test failing mirror complete

Max Reitz qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest5 patches 4 repliesIn review

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block: Add bdrv_qapi_perm_to_blk_perm()block.c include/block/block.h+19 -01 reply
2/5block: Use bdrv_qapi_perm_to_blk_perm()block.c+8 -211 reply
3/5blkdebug: Allow taking/unsharing permissionsblock/blkdebug.c qapi/block-core.json+105 -21 reply
4/5iotests: Add @error to wait_until_completedtests/qemu-iotests/iotests.py+12 -60 replies
5/5iotests: Add test for failing mirror completetests/qemu-iotests/041 tests/qemu-iotests/041.out+46 -20 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJohn SnowVladimir Sementsov-Ogievskiy
1/5R-b
2/5R-b
3/5R-b
4/5R-b R-b
5/5R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete

Hi,

v3 of this series was this:

https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00868.html

In the meantime, I’ve merged the first patch, so the subject of the series has changed.

In v4, I’ve tried to address Vladimir’s concern of how to map QAPI BlockPermission values to BLK_PERM_* flags with the new patches 1 and 2, and a minor change to patch 3:
- Patch 1: Added, this new function will translate QAPI BlockPermission values to BLK_PERM_* flags
- Patch 2: Added; we can make use of the new function in xdbg_graph_add_edge() to save some LoC
- Patch 3:
- %s/4.2/5.0/
- Let blkdebug_parse_perm_list() initialize *dest
- Use bdrv_qapi_perm_to_blk_perm() to translate QAPI BlockPermission

    values instead of blindly assuming an x -> 2^x mapping

git-backport-diff against v3:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/5:[down] 'block: Add bdrv_qapi_perm_to_blk_perm()' 002/5:[down] 'block: Use bdrv_qapi_perm_to_blk_perm()' 003/5:[0008] [FC] 'blkdebug: Allow taking/unsharing permissions' 004/5:[----] [--] 'iotests: Add @error to wait_until_completed' 005/5:[----] [--] 'iotests: Add test for failing mirror complete'

Max Reitz (5):
block: Add bdrv_qapi_perm_to_blk_perm()
block: Use bdrv_qapi_perm_to_blk_perm()
blkdebug: Allow taking/unsharing permissions
iotests: Add @error to wait_until_completed
iotests: Add test for failing mirror complete

 block.c                       | 47 ++++++++++--------
 block/blkdebug.c              | 93 ++++++++++++++++++++++++++++++++++-
 include/block/block.h         |  1 +
 qapi/block-core.json          | 14 +++++-
 tests/qemu-iotests/041        | 44 +++++++++++++++++
 tests/qemu-iotests/041.out    |  4 +-
 tests/qemu-iotests/iotests.py | 18 ++++---
 7 files changed, 190 insertions(+), 31 deletions(-)
Signature · 1 line
2.23.0