Skip to content

common: Further reduce common.h

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20191108210211.GO19317@bill-the-cat

Versions newest first

  1. v2 Latest37 of 41 patches 0 repliesNew

37 of 41 patches are in this archive. The cover letter announces 41.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/41common: Drop global inclusion of status_led.h+0 -00 replies
4/41status_led: Tidy up the code style+0 -00 replies
5/41common: Move random-number functions into their own header+0 -01 reply
5/41common: Move random-number functions into their own header+0 -00 replies
6/41common: Drop linux/crc8.h+0 -00 replies
7/41crc: Fix code style with crc functions+0 -00 replies
8/41crc32: Use the crc.h header for crc functions+0 -00 replies
9/41spl: bootcount: Move code out of header file+0 -00 replies
10/41common: Move bootcount functions to their header file+0 -00 replies
11/41common: Move sorting functions to their own header file+0 -00 replies
12/41Move strtomhz() to vsprintf.h+0 -00 replies
13/41common: Move env_get_ip() to net.h+0 -00 replies
14/41serial: usb: Correct the usbtty_...() prototypes+0 -00 replies
15/41common: Move serial_printf() to the serial header+0 -00 replies
16/41common: Move serial functions out of common.h+0 -00 replies
17/41common: Add a new lz4.h header file+0 -00 replies
18/41common: Move some time functions out of common.h+0 -00 replies
19/41common: Move wait_ticks functions out of common.h+0 -00 replies
20/41common: Move timer_get_us() function out of common.h+0 -00 replies
21/41common: Move get_ticks() function out of common.h+0 -00 replies
22/41common: Move mii_init() function out of common.h+0 -00 replies
24/41common: Drop cpu_init()+0 -00 replies
25/41common: Move checkcpu() out of common.h+0 -00 replies
27/41arm: powerpc: Tidy up code style for cache functions+0 -00 replies
29/41common: Drop checkicache() and checkdcache()+0 -00 replies
31/41arm: powerpc: Tidy up code style for interrupt functions+0 -00 replies
32/41common: Move interrupt functions into a new header+0 -01 reply
32/41common: Move interrupt functions into a new header+0 -00 replies
33/41common: Move enable/disable_interrupts out of common.h+0 -00 replies
34/41common: Move command functions out of common.h+0 -00 replies
35/41common: Drop board_show_dram()+0 -00 replies
36/41common: Move board_get_usable_ram_top() out of common.h+0 -00 replies
37/41common: Move some board functions out of common.h+0 -00 replies
38/41common: Move pci_init_board() out of common.h+0 -00 replies
39/41common: Move trap_init() out of common.h+0 -00 replies
40/41common: Drop get_endaddr()+0 -00 replies
41/41common: Move old EEPROM functions into a new header+0 -00 replies

Reviews trailers per patch

30 of 37 patches have a Reviewed-by or Acked-by.

PatchTom Rini
3/41R-b
4/41R-b
5/41R-b
5/41R-b
6/41R-b
7/41R-b
8/41R-b
9/41
10/41R-b
11/41R-b
12/41
13/41R-b
14/41R-b
15/41R-b
16/41R-b
17/41R-b
18/41R-b
19/41
20/41R-b
21/41R-b
22/41R-b
24/41R-b
25/41R-b
27/41R-b
29/41R-b
31/41R-b
32/41
32/41
33/41
34/41R-b
35/41R-b
36/41R-b
37/41R-b
38/41R-b
39/41R-b
40/41R-b
41/41

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 00/41] common: Further reduce common.h
Quoted 64 lines · Simon Glass

Hi Tom,

Quoted 61 lines · Tom Rini
Quoted 58 lines · Simon Glass

Hi Tom,

Quoted 43 lines · Simon Glass

This series drops the size of common.h down further, by moving things out into existing and new header files.

It is now down to about 200 lines.

Changes in v2:
- Move trap_init() into init.h instead; update commit message

Simon Glass (41):
common: Move legacy CPU functions to their own header Drop CONFIG_SHOW_ACTIVITY
common: Drop global inclusion of status_led.h
status_led: Tidy up the code style
common: Move random-number functions into their own header
common: Drop linux/crc8.h
crc: Fix code style with crc functions
crc32: Use the crc.h header for crc functions
spl: bootcount: Move code out of header file
common: Move bootcount functions to their header file
common: Move sorting functions to their own header file Move strtomhz() to vsprintf.h
common: Move env_get_ip() to net.h
serial: usb: Correct the usbtty_...() prototypes
common: Move serial_printf() to the serial header
common: Move serial functions out of common.h
common: Add a new lz4.h header file
common: Move some time functions out of common.h
common: Move wait_ticks functions out of common.h
common: Move timer_get_us() function out of common.h
common: Move get_ticks() function out of common.h
common: Move mii_init() function out of common.h
common: Move some CPU functions out of common.h
common: Drop cpu_init()
common: Move checkcpu() out of common.h
common: Move some SMP functions out of common.h
arm: powerpc: Tidy up code style for cache functions
common: Move some cache and MMU functions out of common.h
common: Drop checkicache() and checkdcache()
common: Move ARM cache operations out of common.h
arm: powerpc: Tidy up code style for interrupt functions
common: Move interrupt functions into a new header
common: Move enable/disable_interrupts out of common.h

Quoted 9 lines

common: Move command functions out of common.h
common: Drop board_show_dram()
common: Move board_get_usable_ram_top() out of common.h
common: Move some board functions out of common.h
common: Move pci_init_board() out of common.h
common: Move trap_init() out of common.h
common: Drop get_endaddr()
common: Move old EEPROM functions into a new header

I'm sorry I just noticed that this was waiting on a new rev. Only minor changes, mostly a rebase.

Quoted 7 lines
Quoted 3 lines

Thanks. I recall Daniel was a big concerned about calling some stuff "legacy" that wasn't so much legacy as "doesn't / shouldn't be DMified", was that addressed too?

I changed the patch that he commented on, so we'll see.

But I'm open to other adjustments...

OK, I'll take a harder look, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191108/02108933/attachment.sig>