Skip to content

btrfs: Fix build warnings for arm

Andreas Färber linux-arm-kernel linux-btrfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: tree-checker: Fix error format stringfs/btrfs/tree-checker.c+1 -13 replies
2/2btrfs: extent-tree: Fix error format stringfs/btrfs/extent-tree.c+1 -10 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchGeert Uytterhoeven
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH next 0/2] btrfs: Fix build warnings for arm

Hello Wenruo and Dave,

This mini-series fixes two build warnings found while cross-compiling for arm, using openSUSE's cross-arm-binutils and cross-arm-none-gcc9 packages.

Replacing BUG_ON() with btrfs_crit() error handling is noble work, but please be careful not to hardcode format specifiers for x86_64's size_t.

https://www.kernel.org/doc/Documentation/printk-formats.txt

In one case it could've been noticed during review, in another it was hidden through a macro and would've only been found through compile-testing. Probably a 32-bit i386 build would do; otherwise ARCH=arm multi_v7_defconfig plus CONFIG_BTRFS_FS should reproduce.

It's around for maybe three weeks, so I wonder why kbuild bot didn't catch it.

Cheers,
Andreas

Andreas Färber (2):
btrfs: tree-checker: Fix error format string
btrfs: extent-tree: Fix error format string

 fs/btrfs/extent-tree.c  | 2 +-
 fs/btrfs/tree-checker.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.16.4