Skip to content

RFC Change page_pool timeout handling

Jonathan Lemon netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1page_pool: do not release pool until inflight == 0.drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/net/page_pool.h include/net/xdp_priv.h +3 more+138 -1895 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/1] Change page_pool timeout handling

It isn't safe to remove the page pool until all in-flight pages are returned. If the pages are handed up the stack, it might be a while before they are returned.

The page pool can also be used independently of xdp, so it shouldn't be depending on timeout handling from xdp. Change things around so the pool handles its own timeout.

I wanted to send this out to clarify how I see things working. This is currently being tested with the mlx4/mlx5 drivers for attaching DMA-mapped pages to skbs, sending them up the stack, and then putting them back in the page pool afterwards.

Jonathan Lemon (1):
page_pool: do not release pool until inflight == 0.

 .../net/ethernet/stmicro/stmmac/stmmac_main.c |   4 +-
 include/net/page_pool.h                       |  55 +++-----
 include/net/xdp_priv.h                        |   4 -
 include/trace/events/xdp.h                    |  19 +--
 net/core/page_pool.c                          | 115 ++++++++++------
 net/core/xdp.c                                | 130 +++++++-----------
 6 files changed, 138 insertions(+), 189 deletions(-)
Signature · 1 line
2.17.1