Skip to content

getting rid of sha1_to_hex()

Jeff King git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hex: drop sha1_to_hex_r()cache.h contrib/coccinelle/object_id.cocci hex.c+0 -231 reply
2/2hex: drop sha1_to_hex()cache.h contrib/coccinelle/object_id.cocci hex.c +1 more+2 -2310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] getting rid of sha1_to_hex()

I happened to be looking at the oid_to_hex() family of functions today, and noticed that we can drop some of the sha1-specific ones.

It's a minor cleanup in terms of text, but it feels like a nice milestone. :)

[1/2]: hex: drop sha1_to_hex_r()
[2/2]: hex: drop sha1_to_hex()

 cache.h                            |  4 +---
 contrib/coccinelle/object_id.cocci | 32 ------------------------------
 hex.c                              | 10 ----------
 sha1dc_git.c                       |  2 +-
 4 files changed, 2 insertions(+), 46 deletions(-)

-Peff