Skip to content

Use void pointers instead of char in I2C transfer APIs

Dmitry Torokhov linux-i2c linux-iio lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 16 repliesIn review
  2. v21 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- addressed Luca's comments
- added Jonathan's Acked-by
- split put_unaligned_le16 into a separate patch
- more call sites converted to get/put_unaligned_le16
- new patch using memcpy() for moving data around

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3i2c: use void pointers for supplying data for reads and writesdrivers/i2c/i2c-core-base.c drivers/i2c/i2c-core-smbus.c drivers/iio/adc/max1363.c +1 more+33 -285 replies
2/3i2c: smbus: use get/put_unaligned_le16 when working with word datadrivers/i2c/i2c-core-smbus.c+5 -75 replies
3/3i2c: smbus: switch from loops to memcpydrivers/i2c/i2c-core-smbus.c+5 -105 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronLuca CeresoliUwe Kleine-König
1/3A-b R-b
2/3R-b
3/3R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] Use void pointers instead of char in I2C transfer APIs

While we indeed often deal with a stream of bytes when executing a transfer, at the higher layers we usually work with more structured data, and there is not really a reason to require casts to u8 * form the callers. These series change I2C APIs to accept [const] void pointers, and also adjust SMBUS implementation to use get/put_unaligned_16() and memcpy() for moving data around.

Changes in v3:
- addressed Luca's comments
- added Jonathan's Acked-by
- split put_unaligned_le16 into a separate patch
- more call sites converted to get/put_unaligned_le16
- new patch using memcpy() for moving data around

Changes in v2:
- adjusted max1363 to the new i2c_master_send/recv signatures

Dmitry Torokhov (3):
i2c: use void pointers for supplying data for reads and writes
i2c: smbus: use get/put_unaligned_le16 when working with word data
i2c: smbus: switch from loops to memcpy

 drivers/i2c/i2c-core-base.c  |  2 +-
 drivers/i2c/i2c-core-smbus.c | 40 +++++++++++++++---------------------
 drivers/iio/adc/max1363.c    | 14 +++++++------
 include/linux/i2c.h          | 28 +++++++++++++------------
 4 files changed, 41 insertions(+), 43 deletions(-)
Signature · 1 line
2.24.0.rc1.363.gb1bccd3e3d-goog