Skip to content

Change page_pool timeout handling

Jonathan Lemon netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 3 repliesIn review
  2. v22 patches 3 repliesSuperseded
  3. v11 patch 9 repliesSuperseded

Changes in v3 from the cover letter

- restore tracepoint handling, use atomic_inc_return instead.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1page_pool: do not release pool until inflight == 0.drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/net/page_pool.h include/net/xdp_priv.h +3 more+143 -1873 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchJesper Dangaard BrouerIlias Apalodimas
1/1A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [net-next PATCH v3 0/1] Change page_pool timeout handling

It isn't safe to remove the page pool until all in-flight pages are returned. If the pages are handed up the stack, it might be a while before they are returned.

The page pool can also be used independently of xdp, so it shouldn't be depending on timeout handling from the xdp memory model. Change things around so the pool handles its own timeout.

v3:
- restore tracepoint handling, use atomic_inc_return instead.

v2:
- fix wording in commit log
- fix compile error for !PAGE_POOL case
- revise tracepoint handling

Jonathan Lemon (1):
page_pool: do not release pool until inflight == 0.

 .../net/ethernet/stmicro/stmmac/stmmac_main.c |   4 +-
 include/net/page_pool.h                       |  54 +++-----
 include/net/xdp_priv.h                        |   4 -
 include/trace/events/xdp.h                    |  19 +--
 net/core/page_pool.c                          | 124 ++++++++++-------
 net/core/xdp.c                                | 125 +++++++-----------
 6 files changed, 143 insertions(+), 187 deletions(-)
Signature · 1 line
2.17.1