Skip to content

RFC rebase --edit-todo --exec

Andrei Rybak git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest4 patches 3 repliesIn review
  2. v13 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4builtin/rebase.c: reuse loop variablebuiltin/rebase.c+0 -41 reply
2/4rebase: prepare cmd before choosing actionbuiltin/rebase.c+13 -132 replies
3/4rebase: extract add_exec()builtin/rebase.c+12 -50 replies
4/4rebase -i: allow --edit-todo with --execDocumentation/git-rebase.txt builtin/rebase.c t/t3404-rebase-interactive.sh+41 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/4] rebase --edit-todo --exec

Differences from v1:
- Added missing RFC marker.
- Fixed CC list.
- Addressed Junio's comment about masked variable in a for loop: another preparatory patch is added.
- Cleaned up copy-pasted unused code in the new test.

----

Original cover letter:
I've wanted this feature for a long time, and now with rebase working without forking rebase--interactive (thanks to Phillip Wood for working on that), I finally got around to implementing it.

It still needs validation for arguments. Right now, I have two ideas:

1. iterate over original argv and make sure its just '--exec's with its arguments.
2. check all other vars in options[].

Andrei Rybak (4):
builtin/rebase.c: reuse loop variable
rebase: prepare cmd before choosing action
rebase: extract add_exec()
rebase -i: allow --edit-todo with --exec

 Documentation/git-rebase.txt  |  3 +-
 builtin/rebase.c              | 63 +++++++++++++++++++++--------------
 t/t3404-rebase-interactive.sh | 32 ++++++++++++++++++
 3 files changed, 72 insertions(+), 26 deletions(-)
Signature · 1 line
2.24.0.windows.2