gitweb: quote base url more consistently
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | t9502: pass along all arguments in xss helpert/ | +2 | 0 replies | |
| 2/4 | t/gitweb-lib.sh: drop confusing quotest/ | +2 | 0 replies | |
| 3/4 | t/gitweb-lib.sh: set $REQUEST_URIt/ | +2 | 0 replies | |
| 4/4 | gitweb: escape URLs generated by href()gitweb/ t/ | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] gitweb: quote base url more consistently
This series fixes an XSS issue reported to the git-security list where gitweb doesn't always quote its base url, meaning a specially-crafted URL can inject HTML into the finished page. Given the relatively low severity of the problem and my lack of familiarity with gitweb, it makes sense to me to just discuss this one in the open.
Credit for the finding the problem (and some patient explanations) goes to NAKAYAMA DAISUKE <[email protected]>.
[1/4]: t9502: pass along all arguments in xss helper [2/4]: t/gitweb-lib.sh: drop confusing quotes [3/4]: t/gitweb-lib.sh: set $REQUEST_URI [4/4]: gitweb: escape URLs generated by href()
gitweb/gitweb.perl | 31 +++++++++++++---------- t/gitweb-lib.sh | 7 ++--- t/t9502-gitweb-standalone-parse-output.sh | 7 ++--- 3 files changed, 25 insertions(+), 20 deletions(-)
-Peff