Skip to content

Fix misaligned ovl_fh

Amir Goldstein linux-fsdevel linux-unionfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 0 repliesNew

Changes since RFC from the cover letter

- Fix bug in ovl_verify_index()
- Open code ovl_dentry_to_fh() [Al]
- Zero buffer in ovl_encode_real_fh() [Al]
- Support decoding old (misaligned) file handles from the wire [Al]
- Add patch to simplify memory allocation in ovl_encode_real_fh() [Al]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ovl: make sure that real fid is 32bit aligned in memoryfs/overlayfs/copy_up.c fs/overlayfs/export.c fs/overlayfs/namei.c +1 more+115 -730 replies
2/2ovl: don't use a temp buf for encoding real fhfs/overlayfs/copy_up.c+16 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Fix misaligned ovl_fh

Miklos,

Beyond the regular tests, this has also been tortured
with my ovl-nested patches and tests.
Those have been very useful in flushing out nfs export bugs in the past and they have also flushed out a few bugs from the RFC patch I sent yesterday.

Thanks,
Amir.

Changes since RFC:
- Fix bug in ovl_verify_index()
- Open code ovl_dentry_to_fh() [Al]
- Zero buffer in ovl_encode_real_fh() [Al]
- Support decoding old (misaligned) file handles from the wire [Al]
- Add patch to simplify memory allocation in ovl_encode_real_fh() [Al]

Amir Goldstein (2):
ovl: make sure that real fid is 32bit aligned in memory
ovl: don't use a temp buf for encoding real fh

 fs/overlayfs/copy_up.c   | 53 +++++++++++++-------------
 fs/overlayfs/export.c    | 80 ++++++++++++++++++++++++----------------
 fs/overlayfs/namei.c     | 44 +++++++++++-----------
 fs/overlayfs/overlayfs.h | 34 ++++++++++++++---
 4 files changed, 124 insertions(+), 87 deletions(-)
Signature · 1 line
2.17.1