Skip to content

block-copy improvements: part I

Vladimir Sementsov-Ogievskiy qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 2 repliesApplied
  2. v39 patches 15 repliesSuperseded
  3. v27 patches 32 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC24 patches3 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/9job: refactor progress to separate objectblockjob.c include/qemu/job.h include/qemu/progress_meter.h +3 more+76 -250 replies
2/9block/block-copy: fix progress calculationblock/backup.c block/block-copy.c include/block/block-copy.h+19 -250 replies
3/9block/block-copy: specialcase first copy_range requestblock/block-copy.c+31 -100 replies
4/9block/block-copy: use block_statusblock/block-copy.c block/trace-events+61 -130 replies
5/9block/block-copy: factor out find_conflicting_inflight_reqblock/block-copy.c+19 -120 replies
6/9block/block-copy: refactor interfaces to use bytes instead of endblock/block-copy.c include/block/block-copy.h+44 -400 replies
7/9block/block-copy: rename start to offset in interfacesblock/block-copy.c include/block/block-copy.h+43 -430 replies
8/9block/block-copy: reduce intersecting request lockblock/block-copy.c+105 -240 replies
9/9block/block-copy: hide structure definitionsblock/backup-top.c block/backup.c block/block-copy.c +1 more+80 -620 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchAndrey ShinkevichMax Reitz
1/9R-b R-b
2/9R-b
3/9R-b R-b
4/9R-b R-b
5/9R-b R-b
6/9R-b R-b
7/9R-b R-b
8/9R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] block-copy improvements: part I

v4:

01: add Max's r-b
02: rm ProgressResetCallbackFunc typedef
03-06: add Max's r-b
07: fix indentation
08: update in_flight_bytes in block_copy_inflight_req_shrink
improve comment above block_copy() definition
09: add Andrey's and Max's r-b
drop hunk fixing indentation (merged to 07)

Vladimir Sementsov-Ogievskiy (9):
job: refactor progress to separate object block/block-copy: fix progress calculation block/block-copy: specialcase first copy_range request block/block-copy: use block_status
block/block-copy: factor out find_conflicting_inflight_req block/block-copy: refactor interfaces to use bytes instead of end block/block-copy: rename start to offset in interfaces block/block-copy: reduce intersecting request lock block/block-copy: hide structure definitions

 include/block/block-copy.h    |  65 +-----
 include/qemu/job.h            |  11 +-
 include/qemu/progress_meter.h |  58 +++++
 block/backup-top.c            |   6 +-
 block/backup.c                |  38 ++--
 block/block-copy.c            | 405 ++++++++++++++++++++++++++--------
 blockjob.c                    |  16 +-
 job-qmp.c                     |   4 +-
 job.c                         |   6 +-
 qemu-img.c                    |   6 +-
 block/trace-events            |   1 +
 11 files changed, 420 insertions(+), 196 deletions(-)
 create mode 100644 include/qemu/progress_meter.h
Signature · 1 line
2.21.0