python/qemu: New accel module and improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 2 repliesIn review
- v35 patches 3 repliesSuperseded
- v24 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 5 replies | Superseded |
Changes in v4 from the cover letter
- Cleaned up Review-by statements (patch 02) [crosa]
- Let LOG.debug() format the log message (patch 02) [crosa]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | python/qemu: Move kvm_available() to its own modulepython/ python/ tests/ | +33 | 0 replies | |
| 2/5 | python/qemu: accel: Add list_accel() methodpython/ | +23 | 1 reply | |
| 3/5 | python/qemu: accel: Strengthen kvm_available() checkspython/ | +21 | 0 replies | |
| 4/5 | python/qemu: accel: Add tcg_available() methodpython/ | +8 | 0 replies | |
| 5/5 | python/qemu: Remove unneeded imports in __init__python/ | +0 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Alex Bennée | Philippe Mathieu-Daudé | Cleber Rosa |
|---|---|---|---|
| 1/5 | R-b | R-b | |
| 2/5 | R-b T-b | ||
| 3/5 | R-b | R-b | R-b T-b |
| 4/5 | R-b | R-b | R-b T-b |
| 5/5 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/5] python/qemu: New accel module and improvements
On commit abf0bf998dcb John Snow moved some code out of __init__.py to machine.py. kvm_available() remained in though. So on patch 01 I continue his work by creating a home for that method (the new 'accel' module). Honestly I was unsure about whether move the code to any existing module or make a new, but since I am adding more methods related with accelerators then I thought they would deserve a module.
The patches 02-04 introduce new helpers and make improvements. Later I intend to use those methods on the acceptance tests such as to automatically set the accelerator in QEMUMachine VM via Avocado tags, and skip the test if the accelerator is not available.
Patch 05 just remove unneeded imports in __init__.py
Changes v3 -> v4:
- Cleaned up Review-by statements (patch 02) [crosa]
- Let LOG.debug() format the log message (patch 02) [crosa]
Changes v2 -> v3:
- Refactor subprocess.check_output() call (patch 02) [crosa] Not using shell=True
Pass universal_newlines=True so don't need to decode() the output Do not check if returned accelerator's name is empty string
- New patch 05 [crosa]
On patch 01 Cleber suggested to remove unneeded imports in python/qemu/__init__.py
Changes v1 -> v2:
- Removed 'Based on qmp.py' from python/qemu/accel.py (patch 01) [alex.bennee]
- logging added only when used on python/qemu/accel.py (patch 02) [alex.bennee]
Git:
- Tree: https://github.com/wainersm/qemu
- Branch: python_accel_v4
CI:
- Travis (RUNNING): https://travis-ci.org/wainersm/qemu/builds/625827750
Wainer dos Santos Moschetta (5):
python/qemu: Move kvm_available() to its own module python/qemu: accel: Add list_accel() method python/qemu: accel: Strengthen kvm_available() checks python/qemu: accel: Add tcg_available() method python/qemu: Remove unneeded imports in __init__
python/qemu/__init__.py | 24 ------------- python/qemu/accel.py | 77 +++++++++++++++++++++++++++++++++++++++++ tests/vm/basevm.py | 2 +- 3 files changed, 78 insertions(+), 25 deletions(-) create mode 100644 python/qemu/accel.py
Signature · 1 line
2.23.0