Skip to content

RFC virtiofsd, vhost-user-fs: Add support for notification queue

Vivek Goyal qemu-devel virtio-fs 2 versions – Applied

Status from this message: I've merged that 1/5 into my world.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest5 patches 2 repliesApplied
  2. v1 RFC4 patches 14 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5virtiofsd: Get rid of unused fields in fv_QueueInfocontrib/virtiofsd/fuse_virtio.c+0 -62 replies
2/5virtiofsd: Release file locks using F_UNLCKcontrib/virtiofsd/passthrough_ll.c+21 -100 replies
3/5virtiofd: Create a notification queuecontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_virtio.c hw/virtio/vhost-user-fs-pci.c +3 more+87 -310 replies
4/5virtiofsd: Specify size of notification buffer using config spacecontrib/virtiofsd/fuse_virtio.c hw/virtio/vhost-user-fs.c include/hw/virtio/vhost-user-fs.h +1 more+61 -00 replies
5/5virtiofsd: Implement blocking posix lockscontrib/virtiofsd/fuse_kernel.h contrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_lowlevel.h +2 more+185 -160 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchDr. David Alan Gilbert
1/5R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] [RFC] virtiofsd, vhost-user-fs: Add support for notification queue

Hi,

Here is V2 of RFC patches for adding a notification queue to vhost-user-fs device to send notifications from host to guest. It also has patches to support remote posix locks which make use of this newly introduced notification queue.

I have taken care of most of the comments from last iteration. Still one major TODO item is to be able to interrupt/stop blocked thrads for locks when guest reboots.

Patches are also available here.

https://github.com/rhvgoyal/qemu/commits/blocking-locks-v2

Associated kernel changes are available here.

https://github.com/rhvgoyal/linux/commits/blocking-locks-v2

Thanks
Vivek

Vivek Goyal (5):
virtiofsd: Get rid of unused fields in fv_QueueInfo
virtiofsd: Release file locks using F_UNLCK
virtiofd: Create a notification queue
virtiofsd: Specify size of notification buffer using config space
virtiofsd: Implement blocking posix locks

 contrib/virtiofsd/fuse_i.h                 |   1 +
 contrib/virtiofsd/fuse_kernel.h            |   7 +
 contrib/virtiofsd/fuse_lowlevel.c          |  23 ++-
 contrib/virtiofsd/fuse_lowlevel.h          |  25 +++
 contrib/virtiofsd/fuse_virtio.c            | 208 +++++++++++++++++----
 contrib/virtiofsd/passthrough_ll.c         |  80 ++++++--
 hw/virtio/vhost-user-fs-pci.c              |   2 +-
 hw/virtio/vhost-user-fs.c                  |  63 ++++++-
 include/hw/virtio/vhost-user-fs.h          |   3 +
 include/standard-headers/linux/virtio_fs.h |   5 +
 10 files changed, 354 insertions(+), 63 deletions(-)
Signature · 1 line
2.20.1