NCP v2 patch set
Get series with b4
b4 am [email protected]...Versions newest first · linked by author and title
- v4 Latest5 patches 9 repliesIn review
- v34 of 5 patches 3 repliesSuperseded
- v21 of 4 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 10 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | Only announce IV_NCP=2 when we are willing to support these ciphersdoc/ src/ src/ +1 more | +7 | 2 replies | |
| 2/5 | Add strsep compat functionconfigure.ac src/ src/ +2 more | +69 | 2 replies | |
| 3/5 | Implement dynamic NCP negotiationdoc/ src/ src/ +3 more | +174 | 2 replies | |
| 4/5 | Move NCP related function into a seperate file and add unit testssrc/ src/ src/ +10 more | +544 | 2 replies | |
| 5/5 | Normalise ncp-ciphers option and restrict it to 127 bytesdoc/ src/ src/ +2 more | +115 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Lev Stipakov | David Sommerseth |
|---|---|---|
| Series | A-b | |
| 1/5 | A-b | |
| 2/5 | A-b | |
| 3/5 | A-b | |
| 4/5 | A-b | |
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Openvpn-devel] [PATCH v4 0/5] NCP v2 patch set
Resend all patches to make applying them easier and sort them into the order they should be applied to keep Windows happy
Arne Schwabe (5):
Only announce IV_NCP=2 when we are willing to support these ciphers Add strsep compat function
Implement dynamic NCP negotiation
Move NCP related function into a seperate file and add unit tests Normalise ncp-ciphers option and restrict it to 127 bytes
configure.ac | 2 +- doc/openvpn.8 | 13 +- src/compat/Makefile.am | 1 + src/compat/compat-strsep.c | 61 ++++++ src/compat/compat.h | 4 + src/compat/compat.vcxproj | 3 +- src/openvpn/Makefile.am | 1 + src/openvpn/init.c | 3 +- src/openvpn/multi.c | 1 + src/openvpn/openvpn.vcxproj | 2 + src/openvpn/openvpn.vcxproj.filters | 8 +- src/openvpn/options.c | 15 +- src/openvpn/push.c | 32 +++- src/openvpn/ssl.c | 85 +-------- src/openvpn/ssl.h | 31 --- src/openvpn/ssl_common.h | 2 +- src/openvpn/ssl_ncp.c | 274 +++++++++++++++++++++++++++ src/openvpn/ssl_ncp.h | 116 ++++++++++++ tests/unit_tests/openvpn/Makefile.am | 18 +- tests/unit_tests/openvpn/test_ncp.c | 207 ++++++++++++++++++++ 20 files changed, 752 insertions(+), 127 deletions(-) create mode 100644 src/compat/compat-strsep.c create mode 100644 src/openvpn/ssl_ncp.c create mode 100644 src/openvpn/ssl_ncp.h create mode 100644 tests/unit_tests/openvpn/test_ncp.c
Signature · 1 line
2.25.0