Skip to content

NCP v2 patch set

Arne Schwabe openvpn-devel 4 versions – In review

Get series with b4
b4 am [email protected]...

Versions newest first · linked by author and title

  1. v4 Latest5 patches 9 repliesIn review
  2. v34 of 5 patches 3 repliesSuperseded
  3. v21 of 4 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches10 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Only announce IV_NCP=2 when we are willing to support these ciphersdoc/openvpn.8 src/openvpn/init.c src/openvpn/ssl.c +1 more+7 -12 replies
2/5Add strsep compat functionconfigure.ac src/compat/Makefile.am src/compat/compat-strsep.c +2 more+69 -22 replies
3/5Implement dynamic NCP negotiationdoc/openvpn.8 src/openvpn/init.c src/openvpn/push.c +3 more+174 -182 replies
4/5Move NCP related function into a seperate file and add unit testssrc/openvpn/Makefile.am src/openvpn/init.c src/openvpn/multi.c +10 more+544 -2412 replies
5/5Normalise ncp-ciphers option and restrict it to 127 bytesdoc/openvpn.8 src/openvpn/options.c src/openvpn/ssl_ncp.c +2 more+115 -221 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLev StipakovDavid Sommerseth
SeriesA-b
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Openvpn-devel] [PATCH v4 0/5] NCP v2 patch set

Resend all patches to make applying them easier and sort them into the order they should be applied to keep Windows happy

Arne Schwabe (5):
Only announce IV_NCP=2 when we are willing to support these ciphers Add strsep compat function
Implement dynamic NCP negotiation
Move NCP related function into a seperate file and add unit tests Normalise ncp-ciphers option and restrict it to 127 bytes

 configure.ac                         |   2 +-
 doc/openvpn.8                        |  13 +-
 src/compat/Makefile.am               |   1 +
 src/compat/compat-strsep.c           |  61 ++++++
 src/compat/compat.h                  |   4 +
 src/compat/compat.vcxproj            |   3 +-
 src/openvpn/Makefile.am              |   1 +
 src/openvpn/init.c                   |   3 +-
 src/openvpn/multi.c                  |   1 +
 src/openvpn/openvpn.vcxproj          |   2 +
 src/openvpn/openvpn.vcxproj.filters  |   8 +-
 src/openvpn/options.c                |  15 +-
 src/openvpn/push.c                   |  32 +++-
 src/openvpn/ssl.c                    |  85 +--------
 src/openvpn/ssl.h                    |  31 ---
 src/openvpn/ssl_common.h             |   2 +-
 src/openvpn/ssl_ncp.c                | 274 +++++++++++++++++++++++++++
 src/openvpn/ssl_ncp.h                | 116 ++++++++++++
 tests/unit_tests/openvpn/Makefile.am |  18 +-
 tests/unit_tests/openvpn/test_ncp.c  | 207 ++++++++++++++++++++
 20 files changed, 752 insertions(+), 127 deletions(-)
 create mode 100644 src/compat/compat-strsep.c
 create mode 100644 src/openvpn/ssl_ncp.c
 create mode 100644 src/openvpn/ssl_ncp.h
 create mode 100644 tests/unit_tests/openvpn/test_ncp.c
Signature · 1 line
2.25.0