Skip to content

scis: don't apply per-LUN queue depth for SSD

Ming Lei linux-block linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4scsi: megaraid_sas: use private counter for tracking inflight per-LUN commandsdrivers/scsi/megaraid/megaraid_sas.h drivers/scsi/megaraid/megaraid_sas_base.c drivers/scsi/megaraid/megaraid_sas_fusion.c+23 -64 replies
2/4scsi: mpt3sas: use private counter for tracking inflight per-LUN commandsdrivers/scsi/mpt3sas/mpt3sas_base.c drivers/scsi/mpt3sas/mpt3sas_base.h drivers/scsi/mpt3sas/mpt3sas_scsih.c+16 -31 reply
3/4scsi: sd: register request queue after sd_revalidate_disk is donedrivers/scsi/sd.c+3 -11 reply
4/4scsi: core: don't limit per-LUN queue depth for SSDblock/blk-sysfs.c drivers/scsi/scsi_lib.c drivers/scsi/sd.c+35 -723 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/4R-b
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] scis: don't apply per-LUN queue depth for SSD

Hi,

SCSI's per-LUN queue depth is usually for improving IO merge and balancing IO load among LUNs. blk-mq has provides fair driver tag allocation and managed IRQ balances interrupt load among queues, meantime IO merge doesn't play a big role for SSD, and NVMe doesn't apply per-namespace queue depth.

This patchset tries to don't apply per-LUN queue depth for SSD, then we can avoid the expensive atomic operation on sdev->device_busy. We do understand that this shared counter affects IOPS a lot.

The 1st two patches replaces .device_busy with two private counter for megaraid_sas and mpt3sas to track inflight per-LUN commands since the two drivers need the counter for balancing load, even though it is probably no much use.

The last two patches avoid to operate on sdev->device_busy in IO path for SSD.

Ming Lei (4):
scsi: megaraid_sas: use private counter for tracking inflight per-LUN
commands
scsi: mpt3sas: use private counter for tracking inflight per-LUN
commands
scsi: sd: register request queue after sd_revalidate_disk is done
scsi: core: don't limit per-LUN queue depth for SSD

 block/blk-sysfs.c                           | 14 +++++++++++-
 drivers/scsi/megaraid/megaraid_sas.h        |  1 +
 drivers/scsi/megaraid/megaraid_sas_base.c   | 15 +++++++++++--
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 13 +++++++----
 drivers/scsi/mpt3sas/mpt3sas_base.c         |  3 ++-
 drivers/scsi/mpt3sas/mpt3sas_base.h         |  1 +
 drivers/scsi/mpt3sas/mpt3sas_scsih.c        | 15 +++++++++++--
 drivers/scsi/scsi_lib.c                     | 24 +++++++++++++++------
 drivers/scsi/sd.c                           |  8 ++++++-
 9 files changed, 77 insertions(+), 17 deletions(-)
Cc Sathya Prakash <[email protected]>
Cc Chaitra P B <[email protected]>
Cc Suganath Prabu Subramani <[email protected]>
Cc Kashyap Desai <[email protected]>
Cc Sumit Saxena <[email protected]>
Cc Shivasharan S <[email protected]>
Cc Ewan D. Milne <[email protected]>
Cc Christoph Hellwig <[email protected]>,
Cc Hannes Reinecke <[email protected]>
Cc Bart Van Assche <[email protected]>
Signature · 1 line
2.20.1