Skip to content

ARM: Realtek RTD1195/RTD1295/RTD1395 IRQ mux

Andreas Färber linux-arm-kernel linux-devicetree lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest9 patches 2 repliesIn review
  2. v48 patches 11 repliesSuperseded

Changes in v5 from the cover letter

* Renamed enable/disable to unmask/mask (Marc)
* Factored out ack (Marc)
* Clear all interrupts
* Mapped RTD1195 WDOG_NMI
* Added and mapped RTD1295 WDOG_NMI
* Suppress mapping NMIs and reserved bits (Marc)
* Drop mask checks in mask/unmask (Marc)
* Drop mask check in interrupt handler
* Renamed RTD1295 misc bits with MIS_ for consistency
* Renamed RTD1395 misc bits from MISC_ to MIS_ for consistency
* Renamed irq_chip to distinguish iso vs. misc
* Implemented .irq_get_irqchip_state

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9dt-bindings: interrupt-controller: Add Realtek RTD1195/RTD1295 muxDocumentation/devicetree/bindings/interrupt-controller/realtek,rtd1195-mux.yaml+53 -00 replies
2/9irqchip: Add Realtek RTD1295 mux driverdrivers/irqchip/Makefile drivers/irqchip/irq-rtd1195-mux.c+292 -00 replies
3/9irqchip: rtd1195-mux: Implement irq_get_irqchip_statedrivers/irqchip/irq-rtd1195-mux.c+36 -01 reply
4/9arm64: dts: realtek: rtd129x: Add irq muxes and UART interruptsarch/arm64/boot/dts/realtek/rtd129x.dtsi+22 -00 replies
5/9irqchip: rtd1195-mux: Add RTD1195 definitionsdrivers/irqchip/irq-rtd1195-mux.c+103 -10 replies
6/9ARM: dts: rtd1195: Add irq muxes and UART interruptsarch/arm/boot/dts/rtd1195.dtsi+20 -00 replies
7/9dt-bindings: interrupt-controller: rtd1195-mux: Add RTD1395Documentation/devicetree/bindings/interrupt-controller/realtek,rtd1195-mux.yaml+2 -01 reply
8/9irqchip: rtd1195-mux: Add RTD1395 definitionsdrivers/irqchip/irq-rtd1195-mux.c+84 -10 replies
9/9arm64: dts: realtek: rtd139x: Add irq muxes and UART interruptsarch/arm64/boot/dts/realtek/rtd139x.dtsi+22 -00 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/9A-b
2/9
3/9
4/9
5/9
6/9
7/9A-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/9] ARM: Realtek RTD1195/RTD1295/RTD1395 IRQ mux

Hello,

This series adds two IRQ muxes for the Realtek RTD1195, RTD1295 and RTD1395 SoC families.

The implementation is based on register offsets seen in the vendor DT, split up into two separate nodes, as well as code from QNAP's rtk119x and Synology's RTD1293/96 GPL code dumps and Banana Bi W2/M4 BSP repositories.

v5 cleans up mask/unmask, ack and naming.

From /proc/interrupts on RTD1195:
24: 158 iso 2 Edge ttyS0

From /proc/interrupts on RTD1395:
9: 110 0 0 0 iso 2 Edge ttyS0

The chip name now no longer overflows the columns, but irq type is still wrong.

@Realtek: Patch 8/9 contains a question about RTD1395.

More experimental patches at:
https://github.com/afaerber/linux/commits/rtd1295-next

Have a lot of fun!

Cheers,
Andreas

v4 -> v5:
* Renamed enable/disable to unmask/mask (Marc)
* Factored out ack (Marc)
* Clear all interrupts
* Mapped RTD1195 WDOG_NMI
* Added and mapped RTD1295 WDOG_NMI
* Suppress mapping NMIs and reserved bits (Marc)
* Drop mask checks in mask/unmask (Marc)
* Drop mask check in interrupt handler
* Renamed RTD1295 misc bits with MIS_ for consistency
* Renamed RTD1395 misc bits from MISC_ to MIS_ for consistency
* Renamed irq_chip to distinguish iso vs. misc
* Implemented .irq_get_irqchip_state

v3 -> v4:
* Drop no-op .irq_set_affinity callback (Thomas)
* Disable all interrupts (James)
* Updated SPDX-License-identifier
* Use tabular formatting (Thomas)
* Adopt different braces style (Thomas)
* Use raw_spinlock_t (Thomas)
* Shortened callback name (Thomas)
* Fixed of_iomap() error handling
* Don't mask unmapped NMIs
* Cache SCPU_INT_EN (Thomas)
* Renamed binding and source files
* Dropped UART1/UART2 TO interrupts
* Expanded commit messages
* Added RTD1395 patches

v2 -> v3:
* Rebased, adding nodes to rtd129x.dtsi instead of rtd1295.dtsi
* Adopted {readl,writel}_relaxed() (Marc)
* Adopted spin_lock_irqsave() (Marc)
* Implemented RTD1195
* Implemented mapping for non-linear bits such as i2c3

v1 -> v2:
* Rebased, avoiding dependency on reset series for DT nodes
* Don't forward set_affinity to GIC (Marc)
* Added more spinlocks (Marc)
* Code cleanups
* Investigated quirk
* Fixed spinlock initialization (Andrew)

Cc Thomas Gleixner <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Marc Zyngier <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Aleix Roca Nonell <[email protected]>
Cc James Tai <[email protected]>

Andreas Färber (9):
dt-bindings: interrupt-controller: Add Realtek RTD1195/RTD1295 mux
irqchip: Add Realtek RTD1295 mux driver
irqchip: rtd1195-mux: Implement irq_get_irqchip_state
arm64: dts: realtek: rtd129x: Add irq muxes and UART interrupts
irqchip: rtd1195-mux: Add RTD1195 definitions
ARM: dts: rtd1195: Add irq muxes and UART interrupts
dt-bindings: interrupt-controller: rtd1195-mux: Add RTD1395
irqchip: rtd1195-mux: Add RTD1395 definitions
arm64: dts: realtek: rtd139x: Add irq muxes and UART interrupts

 .../interrupt-controller/realtek,rtd1195-mux.yaml  |  55 +++
 arch/arm/boot/dts/rtd1195.dtsi                     |  20 +
 arch/arm64/boot/dts/realtek/rtd129x.dtsi           |  22 +
 arch/arm64/boot/dts/realtek/rtd139x.dtsi           |  22 +
 drivers/irqchip/Makefile                           |   1 +
 drivers/irqchip/irq-rtd1195-mux.c                  | 512 +++++++++++++++++++++
 6 files changed, 632 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd1195-mux.yaml
 create mode 100644 drivers/irqchip/irq-rtd1195-mux.c
Signature · 1 line
2.16.4