Skip to content

sched/nohz: Make the rest of kcpustat vtime aware v2

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sched/cputime: Support other fields on kcpustat_field()kernel/sched/cputime.c+42 -112 replies
2/6sched/vtime: Bring all-in-one kcpustat accessor for vtime fieldsinclude/linux/kernel_stat.h kernel/sched/cputime.c+142 -202 replies
3/6procfs: Use all-in-one vtime aware kcpustat accessorfs/proc/stat.c+10 -100 replies
4/6cpufreq: Use vtime aware kcpustat accessors for user timedrivers/cpufreq/cpufreq.c drivers/cpufreq/cpufreq_governor.c+12 -70 replies
5/6leds: Use all-in-one vtime aware kcpustat accessordrivers/leds/trigger/ledtrig-activity.c+6 -30 replies
6/6rackmeter: Use vtime aware kcpustat accessordrivers/macintosh/rack-meter.c+4 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] sched/nohz: Make the rest of kcpustat vtime aware v2

(See https://lore.kernel.org/lkml/[email protected]/
for the record)

After review from Peter, I eventually gave up with the idea of fixing the nice fields of kcpustat. Therefore if a nice update happens on a task while it runs on a nohz_full CPU, the whole cputime will be accounted under the nice value observed at accounting time, hence the possibility of a nice VS unnice kcpustat inacurrate distribution.

But that's a lesser evil compared to interrupting a nohz_full CPU, which would be required to fix that. Also users of nohz_full shouldn't care about nice at all since a single task is expected to run on the CPU.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
nohz/kcpustat-v4

HEAD: dd59f186dc21e164097f659b4d60815e232f9555

Thanks,
Frederic
---

Frederic Weisbecker (6):
sched/cputime: Support other fields on kcpustat_field() sched/vtime: Bring all-in-one kcpustat accessor for vtime fields
procfs: Use all-in-one vtime aware kcpustat accessor
cpufreq: Use vtime aware kcpustat accessors for user time
leds: Use all-in-one vtime aware kcpustat accessor
rackmeter: Use vtime aware kcpustat accessor

 drivers/cpufreq/cpufreq.c               |  13 ++-
 drivers/cpufreq/cpufreq_governor.c      |   6 +-
 drivers/leds/trigger/ledtrig-activity.c |   9 +-
 drivers/macintosh/rack-meter.c          |   7 +-
 fs/proc/stat.c                          |  20 ++--
 include/linux/kernel_stat.h             |  23 ++++
 kernel/sched/cputime.c                  | 192 ++++++++++++++++++++++++++------
 7 files changed, 216 insertions(+), 54 deletions(-)