Skip to content

firmware: google: Expose coreboot tables and CBMEM

[email protected] lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 7 repliesIn review
  2. v32 patches 13 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v4 from the cover letter

- Use temporary memremap instead of persistent ioremap
- Constify a struct
- Get rid of unused headers
- Use dev_{get|set}_drvdata
- Use dev_groups to automatically handle attributes
- Updated file description
- Updated ABI documentation

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2firmware: google: Expose CBMEM over sysfsDocumentation/ABI/stable/sysfs-bus-coreboot drivers/firmware/google/Kconfig drivers/firmware/google/Makefile +2 more+196 -05 replies
2/2firmware: google: Expose coreboot tables over sysfsDocumentation/ABI/stable/sysfs-bus-coreboot drivers/firmware/google/coreboot_table.c+88 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSamuel HollandStephen Boyd
1/2R-b T-b
2/2R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] firmware: google: Expose coreboot tables and CBMEM

From: Patrick Rudolph <[email protected]>

As user land tools currently use /dev/mem to access coreboot tables and CBMEM, provide a better way by using read-only sysfs attributes.

Unconditionally expose all tables and buffers making future changes in coreboot possible without modifying a kernel driver.

Changes in v2:
- Add ABI documentation
- Add 0x prefix on hex values
- Remove wrong ioremap hint as found by CI

Changes in v3:
- Use BIN_ATTR_RO

Changes in v4:
- Use temporary memremap instead of persistent ioremap
- Constify a struct
- Get rid of unused headers
- Use dev_{get|set}_drvdata
- Use dev_groups to automatically handle attributes
- Updated file description
- Updated ABI documentation

Patrick Rudolph (2):
firmware: google: Expose CBMEM over sysfs
firmware: google: Expose coreboot tables over sysfs

 Documentation/ABI/stable/sysfs-bus-coreboot |  74 +++++++++++
 drivers/firmware/google/Kconfig             |   9 ++
 drivers/firmware/google/Makefile            |   1 +
 drivers/firmware/google/cbmem-coreboot.c    | 128 ++++++++++++++++++++
 drivers/firmware/google/coreboot_table.c    |  58 +++++++++
 drivers/firmware/google/coreboot_table.h    |  14 +++
 6 files changed, 284 insertions(+)
 create mode 100644 Documentation/ABI/stable/sysfs-bus-coreboot
 create mode 100644 drivers/firmware/google/cbmem-coreboot.c
Signature · 1 line
2.24.1