Skip to content

block: Fix resize (extending) of short overlays

Kevin Wolf qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest10 patches 12 repliesIn review
  2. v610 patches 16 repliesSuperseded
  3. v59 patches 19 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v49 patches20 repliesSuperseded
v38 patches22 repliesSuperseded
v26 patches21 repliesSuperseded
v16 patches20 repliesSuperseded

Changes in v7 from the cover letter

- Allocate smaller zero buffer [Vladimir]
- Added missing error_setg_errno() [Max]
- Code cleanup in the iotest, enabled mapping for 'metadata' [Vladimir]
- Don't assign to errp twice [Eric]

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10block: Add flags to BlockDriver.bdrv_co_truncate()block/crypto.c block/file-posix.c block/file-win32.c +12 more+33 -130 replies
2/10block: Add flags to bdrv(_co)_truncate()block/block-backend.c block/crypto.c block/io.c +10 more+34 -280 replies
3/10block-backend: Add flags to blk_truncate()block.c block/block-backend.c block/commit.c +12 more+22 -210 replies
4/10qcow2: Support BDRV_REQ_ZERO_WRITE for truncateblock/qcow2-cluster.c block/qcow2.c+35 -15 replies
5/10raw-format: Support BDRV_REQ_ZERO_WRITE for truncateblock/raw-format.c+3 -10 replies
6/10file-posix: Support BDRV_REQ_ZERO_WRITE for truncateblock/file-posix.c+4 -00 replies
7/10block: truncate: Don't make backing file data visibleblock/io.c+25 -01 reply
8/10iotests: Filter testfiles out in filter_img_info()tests/qemu-iotests/iotests.py+3 -20 replies
9/10iotests: Test committing to short backing filetests/qemu-iotests/274 tests/qemu-iotests/274.out tests/qemu-iotests/group+424 -02 replies
10/10qcow2: Forward ZERO_WRITE flag for full preallocationblock/qcow2.c tests/qemu-iotests/274.out+21 -52 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchMax ReitzEric BlakeVladimir Sementsov-OgievskiyAlberto Garcia
1/10R-b R-b R-b
2/10R-b R-b R-b
3/10R-b R-b R-b
4/10R-b R-b
5/10R-b R-b R-b
6/10R-b R-b R-b
7/10R-b R-b
8/10R-b R-b
9/10R-b R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/10] block: Fix resize (extending) of short overlays

v7:
- Allocate smaller zero buffer [Vladimir]
- Added missing error_setg_errno() [Max]
- Code cleanup in the iotest, enabled mapping for 'metadata' [Vladimir]
- Don't assign to errp twice [Eric]

v6:
- qcow2: Don't round up end offset [Eric]
- qcow2: Use different error messages for different error paths
- Request BDRV_REQ_ZERO_WRITE only if the backing file actually covers (part of) the new area (fix regression from v3) [Max]
- New patch: Forward ZERO_WRITE flag for full preallocation [Max]

v5:
- Fixed file-win32 [Patchew]
- Fixed zeroing in qcow2 for unaligned requests + tests [Vladimir]
- Made raw-format code more consistent [Eric]
- Leave output for existing iotests cases unchanged [Vladimir]

v4:
- Rewrote the series to move the actual zeroing to the block drivers so that error paths can work correctly and potentially long-running fallback to writing explicit zeroes is avoided.
- Fixed output filtering order in the test case [Max]

v3:
- Don't allow blocking the monitor for a zero write in block_resize (even though we can already blockfor other reasons there). This is mainly responsible for the increased complexity compared to v2. Personally, I think this is not an improvement over v2, but if this is what it takes to fix a corruption issue in 4.2... [Max]
- Don't use huge image files in the test case [Vladimir]

v2:
- Switched order of bs->total_sectors update and zero write [Vladimir]
- Fixed coding style [Vladimir]
- Changed the commit message to contain what was in the cover letter
- Test all preallocation modes
- Test allocation status with qemu-io 'map' [Vladimir]

Kevin Wolf (10):
block: Add flags to BlockDriver.bdrv_co_truncate()
block: Add flags to bdrv(_co)_truncate()
block-backend: Add flags to blk_truncate()
qcow2: Support BDRV_REQ_ZERO_WRITE for truncate
raw-format: Support BDRV_REQ_ZERO_WRITE for truncate
file-posix: Support BDRV_REQ_ZERO_WRITE for truncate
block: truncate: Don't make backing file data visible
iotests: Filter testfiles out in filter_img_info()
iotests: Test committing to short backing file
qcow2: Forward ZERO_WRITE flag for full preallocation

 include/block/block.h          |   5 +-
 include/block/block_int.h      |  10 +-
 include/sysemu/block-backend.h |   2 +-
 block.c                        |   3 +-
 block/block-backend.c          |   4 +-
 block/commit.c                 |   4 +-
 block/crypto.c                 |   7 +-
 block/file-posix.c             |   6 +-
 block/file-win32.c             |   2 +-
 block/gluster.c                |   1 +
 block/io.c                     |  43 +++++-
 block/iscsi.c                  |   2 +-
 block/mirror.c                 |   2 +-
 block/nfs.c                    |   3 +-
 block/parallels.c              |   6 +-
 block/qcow.c                   |   4 +-
 block/qcow2-cluster.c          |   2 +-
 block/qcow2-refcount.c         |   2 +-
 block/qcow2.c                  |  73 +++++++--
 block/qed.c                    |   3 +-
 block/raw-format.c             |   6 +-
 block/rbd.c                    |   1 +
 block/sheepdog.c               |   4 +-
 block/ssh.c                    |   2 +-
 block/vdi.c                    |   2 +-
 block/vhdx-log.c               |   2 +-
 block/vhdx.c                   |   6 +-
 block/vmdk.c                   |   8 +-
 block/vpc.c                    |   2 +-
 blockdev.c                     |   2 +-
 qemu-img.c                     |   2 +-
 qemu-io-cmds.c                 |   2 +-
 tests/test-block-iothread.c    |   9 +-
 tests/qemu-iotests/iotests.py  |   5 +-
 tests/qemu-iotests/274         | 155 +++++++++++++++++++
 tests/qemu-iotests/274.out     | 268 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/group       |   1 +
 37 files changed, 597 insertions(+), 64 deletions(-)
 create mode 100755 tests/qemu-iotests/274
 create mode 100644 tests/qemu-iotests/274.out
Signature · 1 line
2.25.3