Skip to content

at24: move write-protect pin handling to nvmem core

Khouloud Touil linux-devicetree linux-i2c lkml 4 versions – Applied

Status from this message: I picked up patches 1-3 & 5 into the at24 tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 12 repliesApplied
  2. v34 patches 2 repliesSuperseded
  3. v24 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches11 repliesSuperseded

Changes in v4 from the cover letter

-Keep the example of the wp-gpios in the at25 bindings -Add reference for the wp-gpios property in the at25 binding

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: nvmem: new optional property wp-gpiosDocumentation/devicetree/bindings/nvmem/nvmem.yaml+11 -02 replies
2/5nvmem: add support for the write-protect pindrivers/nvmem/core.c drivers/nvmem/nvmem.h include/linux/nvmem-provider.h+22 -24 replies
3/5dt-bindings: at24: make wp-gpios a reference to the property defined by nvmemDocumentation/devicetree/bindings/eeprom/at24.yaml+1 -41 reply
4/5dt-bindings: at25: add reference for the wp-gpios propertyDocumentation/devicetree/bindings/eeprom/at25.txt+2 -04 replies
5/5eeprom: at24: remove the write-protect pin supportdrivers/misc/eeprom/at24.c+0 -90 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijSrinivas KandagatlaRob HerringGreg Kroah-Hartman
1/5R-b R-b
2/5R-b A-b
3/5R-b R-b
4/5R-b A-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] at24: move write-protect pin handling to nvmem core

The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.

Instead of modifying all the drivers to check this pin, make the nvmem subsystem check if the write-protect GPIO being passed through the nvmem_config or defined in the device tree and pull it low whenever writing to the memory.

This patchset:

- adds support for the write-protect pin split into two parts. The first patch modifies modifies the relevant binding document, while the second modifies the nvmem code to pull the write-protect GPIO low (if present) during write operations.

- removes support for the write-protect pin split into two parts. The first patch modifies the relevant binding document to make the wp-gpio a reference to the property defined by nvmem , while the second removes the relevant code in the at24 driver.

- adds reference in the at25 binding document for the wp-gpios property as it uses nvmem subsystem.

Changes since v1:
-Add an explenation on how the wp-gpios works -Keep reference to the wp-gpios in the at24 binding

Changes since v2:
-Use the flag GPIO_ACTIVE_HIGH instead of 0

Changes since v3:
-Keep the example of the wp-gpios in the at25 bindings -Add reference for the wp-gpios property in the at25 binding

Khouloud Touil (5):
dt-bindings: nvmem: new optional property wp-gpios
nvmem: add support for the write-protect pin
dt-bindings: at24: make wp-gpios a reference to the property defined
by nvmem
dt-bindings: at25: add reference for the wp-gpios property
eeprom: at24: remove the write-protect pin support

 .../devicetree/bindings/eeprom/at24.yaml      |  5 +----
 .../devicetree/bindings/eeprom/at25.txt       |  2 ++
 .../devicetree/bindings/nvmem/nvmem.yaml      | 11 +++++++++++
 drivers/misc/eeprom/at24.c                    |  9 ---------
 drivers/nvmem/core.c                          | 19 +++++++++++++++++--
 drivers/nvmem/nvmem.h                         |  2 ++
 include/linux/nvmem-provider.h                |  3 +++
 7 files changed, 36 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1