Skip to content

sched/fair: Task placement biasing using uclamp

Valentin Schneider lkml 3 versions – Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 2 repliesApplied
  2. v24 patches 13 repliesSuperseded
  3. v13 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Collect Reviewed-by
- (new patch) Remove uclamp_util() (Dietmar)
- Make uclamp_eff_value()'s return type unsigned long (Vincent)
- Reword find_energy_efficient_cpu() tweak changelog (Dietmar)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5sched/uclamp: Remove uclamp_util()kernel/sched/sched.h+0 -90 replies
2/5sched/uclamp: Make uclamp util helpers use and return UL valueskernel/sched/core.c kernel/sched/sched.h+10 -100 replies
3/5sched/uclamp: Rename uclamp_util_with() into uclamp_rq_util_with()kernel/sched/cpufreq_schedutil.c kernel/sched/sched.h+6 -50 replies
4/5sched/fair: Make task_fits_capacity() consider uclamp restrictionskernel/sched/fair.c+15 -10 replies
5/5sched/fair: Make EAS wakeup placement consider uclamp restrictionskernel/sched/fair.c+10 -20 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchQuentin PerretVincent GuittotDietmar Eggemann
SeriesR-b T-b
1/5
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] sched/fair: Task placement biasing using uclamp

Hi,

While uclamp restrictions currently only impact schedutil's frequency selection, it would make sense to also let them impact CPU selection in asymmetric topologies. This would let us steer specific tasks towards certain CPU capacities regardless of their actual utilization - I give a few examples in patch 4.

The first three patches are mainly cleanups, the meat of the thing is in patches 4 and 5.

Note that this is in the same spirit as what Patrick had proposed for EAS on Android [1]

[1]: https://android.googlesource.com/kernel/common/+/b61876ed122f816660fe49e0de1b7ee4891deaa2%5E%21

Revisions
=========

Changed in v3:

- Collect Reviewed-by
- (new patch) Remove uclamp_util() (Dietmar)
- Make uclamp_eff_value()'s return type unsigned long (Vincent)
- Reword find_energy_efficient_cpu() tweak changelog (Dietmar)

Changed in v2:

- Collect Reviewed-by

- Make uclamp_task_util() unconditionally use util_est (Quentin)
- Because of the above, move uclamp_task_util() to fair.c

- Split v1's 3/3 into
- task_fits_capacity() tweak (v2's 3/4)
- find_energy_efficient_cpu() tweak (v2's 4/4).

Cheers,
Valentin

Valentin Schneider (5):
sched/uclamp: Remove uclamp_util()
sched/uclamp: Make uclamp util helpers use and return UL values sched/uclamp: Rename uclamp_util_with() into uclamp_rq_util_with() sched/fair: Make task_fits_capacity() consider uclamp restrictions sched/fair: Make EAS wakeup placement consider uclamp restrictions

 kernel/sched/core.c              |  6 +++---
 kernel/sched/cpufreq_schedutil.c |  2 +-
 kernel/sched/fair.c              | 28 +++++++++++++++++++++++++---
 kernel/sched/sched.h             | 24 ++++++++----------------
 4 files changed, 37 insertions(+), 23 deletions(-)

--
2.24.0