Skip to content

qapi: Module fixes and cleanups

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6qapi: Tweak "command returns a nice type" check for clarityscripts/qapi/schema.py+5 -41 reply
2/6tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]tests/Makefile.include+3 -11 reply
3/6qapi: Generate command registration stuff into separate files.gitignore Makefile docs/devel/qapi-code-gen.txt +8 more+46 -112 replies
4/6qapi: Proper intermediate representation for modulesscripts/qapi/schema.py+43 -201 reply
5/6qapi: Fix code generation for empty modulesscripts/qapi/schema.py tests/qapi-schema/empty.out tests/qapi-schema/include-repetition.out +1 more+26 -291 reply
6/6qapi: Simplify QAPISchemaModularCVisitorscripts/qapi/commands.py scripts/qapi/events.py scripts/qapi/gen.py +2 more+23 -221 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric BlakeStefan Berger
SeriesR-b
1/6R-b
2/6R-b
3/6R-b T-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] qapi: Module fixes and cleanups

Kevin recently posted a minimally invasive fix for empty QAPI modules[*]. This is my attempt at a fix that also addresses the design weakness that led to the bug.

Markus Armbruster (6):
qapi: Tweak "command returns a nice type" check for clarity tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]
qapi: Generate command registration stuff into separate files
qapi: Proper intermediate representation for modules
qapi: Fix code generation for empty modules
qapi: Simplify QAPISchemaModularCVisitor

 docs/devel/qapi-code-gen.txt             | 19 ++++-
 Makefile                                 |  4 +-
 monitor/misc.c                           |  7 +-
 qga/main.c                               |  2 +-
 tests/test-qmp-cmds.c                    |  1 +
 .gitignore                               |  1 +
 qapi/Makefile.objs                       |  1 +
 qga/Makefile.objs                        |  1 +
 scripts/qapi/commands.py                 | 17 +++--
 scripts/qapi/events.py                   |  2 +-
 scripts/qapi/gen.py                      | 28 ++++----
 scripts/qapi/schema.py                   | 92 +++++++++++++++---------
 scripts/qapi/types.py                    |  5 +-
 scripts/qapi/visit.py                    |  8 +--
 tests/.gitignore                         |  1 +
 tests/Makefile.include                   |  9 ++-
 tests/qapi-schema/empty.out              |  1 +
 tests/qapi-schema/include-repetition.out |  6 +-
 tests/qapi-schema/qapi-schema-test.out   | 24 +++----
 19 files changed, 144 insertions(+), 85 deletions(-)
Signature · 1 line
2.21.0