Skip to content

PCI: Prefer pcie_capability_read_word()

Bjorn Helgaas amd-gfx dri-devel linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7PCI: Add #defines for Enter Compliance, Transmit Margininclude/uapi/linux/pci_regs.h+2 -00 replies
2/7drm/amdgpu: Correct Transmit Margin masksdrivers/gpu/drm/amd/amdgpu/cik.c drivers/gpu/drm/amd/amdgpu/si.c+8 -80 replies
3/7drm/amdgpu: Replace numbers with PCI_EXP_LNKCTL2 definitionsdrivers/gpu/drm/amd/amdgpu/cik.c drivers/gpu/drm/amd/amdgpu/si.c+28 -160 replies
4/7drm/amdgpu: Prefer pcie_capability_read_word()drivers/gpu/drm/amd/amdgpu/cik.c drivers/gpu/drm/amd/amdgpu/si.c+90 -520 replies
5/7drm/radeon: Correct Transmit Margin masksdrivers/gpu/drm/radeon/cik.c drivers/gpu/drm/radeon/si.c+8 -80 replies
6/7drm/radeon: Replace numbers with PCI_EXP_LNKCTL2 definitionsdrivers/gpu/drm/radeon/cik.c drivers/gpu/drm/radeon/si.c+28 -160 replies
7/7drm/radeon: Prefer pcie_capability_read_word()drivers/gpu/drm/radeon/cik.c drivers/gpu/drm/radeon/si.c+90 -530 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex Deucher
SeriesR-b
1/7R-b
2/7R-b
3/7R-b
4/7
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] PCI: Prefer pcie_capability_read_word()

From: Bjorn Helgaas <[email protected]>

Use pcie_capability_read_word() and similar instead of using pci_read_config_word() directly. Add #defines to replace some magic numbers. Fix typos in use of Transmit Margin field.

These are currently on my pci/misc branch for v5.5. Let me know if you see any issues.

Bjorn Helgaas (5):
PCI: Add #defines for Enter Compliance, Transmit Margin drm/amdgpu: Correct Transmit Margin masks drm/amdgpu: Replace numbers with PCI_EXP_LNKCTL2 definitions drm/radeon: Correct Transmit Margin masks drm/radeon: Replace numbers with PCI_EXP_LNKCTL2 definitions

Frederick Lawler (2):
drm/amdgpu: Prefer pcie_capability_read_word()
drm/radeon: Prefer pcie_capability_read_word()

 drivers/gpu/drm/amd/amdgpu/cik.c | 95 +++++++++++++++++++------------
 drivers/gpu/drm/amd/amdgpu/si.c  | 97 ++++++++++++++++++++------------
 drivers/gpu/drm/radeon/cik.c     | 94 +++++++++++++++++++------------
 drivers/gpu/drm/radeon/si.c      | 97 ++++++++++++++++++++------------
 include/uapi/linux/pci_regs.h    |  2 +
 5 files changed, 243 insertions(+), 142 deletions(-)
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog