Organize code according to IBTA layout
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest48 patches 8 repliesIn review
- v148 patches 10 repliesSuperseded
Changelog from the cover letter
v1->v2: https://lore.kernel.org/linux-rdma/[email protected]
* Added forgotten CM_FIELD64_LOC().v0->v1: https://lore.kernel.org/linux-rdma/[email protected]
* Used Jason's macros as a basis for all get/set operation for wire protocol.
* Fixed wrong offsets.
* Grouped all CM related patches in one patchset bomb.
----------------------------------------------------------------------
Hi,
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/48 | RDMA/cm: Provide private data size to CM usersdrivers/ include/ | +12 | 0 replies | |
| 2/48 | RDMA/srpt: Use private_data_len instead of hardcoded valuedrivers/ | +1 | 0 replies | |
| 3/48 | RDMA/ucma: Mask QPN to be 24 bits according to IBTAdrivers/ drivers/ | +5 | 0 replies | |
| 4/48 | RDMA/cm: Add SET/GET implementations to hide IBA wire formatdrivers/ include/ | +139 | 1 reply | |
| 5/48 | RDMA/cm: Request For Communication (REQ) message definitionsdrivers/ drivers/ drivers/ +2 more | +97 | 1 reply | |
| 6/48 | RDMA/cm: Message Receipt Acknowledgment (MRA) message definitionsdrivers/ drivers/ include/ +1 more | +11 | 0 replies | |
| 7/48 | RDMA/cm: Reject (REJ) message definitionsdrivers/ drivers/ drivers/ +2 more | +17 | 0 replies | |
| 8/48 | RDMA/cm: Reply To Request for communication (REP) definitionsdrivers/ drivers/ drivers/ +2 more | +23 | 0 replies | |
| 9/48 | RDMA/cm: Ready To Use (RTU) definitionsdrivers/ drivers/ include/ +1 more | +9 | 0 replies | |
| 10/48 | RDMA/cm: Request For Communication Release (DREQ) definitionsdrivers/ drivers/ include/ +1 more | +10 | 0 replies | |
| 11/48 | RDMA/cm: Reply To Request For Communication Release (DREP) definitionsdrivers/ drivers/ include/ +1 more | +9 | 0 replies | |
| 12/48 | RDMA/cm: Load Alternate Path (LAP) definitionsdrivers/ drivers/ include/ +1 more | +29 | 0 replies | |
| 13/48 | RDMA/cm: Alternate Path Response (APR) message definitionsdrivers/ drivers/ include/ +1 more | +16 | 0 replies | |
| 14/48 | RDMA/cm: Service ID Resolution Request (SIDR_REQ) definitionsdrivers/ drivers/ drivers/ +2 more | +11 | 0 replies | |
| 15/48 | RDMA/cm: Service ID Resolution Response (SIDR_REP) definitionsdrivers/ drivers/ drivers/ +2 more | +21 | 0 replies | |
| 16/48 | RDMA/cm: Convert QPN and EECN to be u32 variablesdrivers/ drivers/ | +35 | 0 replies | |
| 17/48 | RDMA/cm: Convert REQ responded resources to the new schemedrivers/ drivers/ | +4 | 0 replies | |
| 18/48 | RDMA/cm: Convert REQ initiator depth to the new schemedrivers/ drivers/ | +3 | 0 replies | |
| 19/48 | RDMA/cm: Convert REQ remote response timeoutdrivers/ drivers/ | +3 | 0 replies | |
| 20/48 | RDMA/cm: Simplify QP type to wire protocol translationdrivers/ drivers/ | +25 | 0 replies | |
| 21/48 | RDMA/cm: Convert REQ flow controldrivers/ drivers/ | +2 | 0 replies | |
| 22/48 | RDMA/cm: Convert starting PSN to be u32 variabledrivers/ drivers/ | +12 | 0 replies | |
| 23/48 | RDMA/cm: Update REQ local response timeoutdrivers/ drivers/ | +4 | 0 replies | |
| 24/48 | RDMA/cm: Convert REQ retry count to use new schemedrivers/ drivers/ | +3 | 0 replies | |
| 25/48 | RDMA/cm: Update REQ path MTU fielddrivers/ drivers/ | +4 | 0 replies | |
| 26/48 | RDMA/cm: Convert REQ RNR retry timeout counterdrivers/ drivers/ | +3 | 0 replies | |
| 27/48 | RDMA/cm: Convert REQ MAX CM retriesdrivers/ drivers/ | +2 | 0 replies | |
| 28/48 | RDMA/cm: Convert REQ SRQ fielddrivers/ drivers/ | +2 | 0 replies | |
| 29/48 | RDMA/cm: Convert REQ flow label fielddrivers/ drivers/ | +8 | 0 replies | |
| 30/48 | RDMA/cm: Convert REQ packet ratedrivers/ drivers/ | +4 | 0 replies | |
| 31/48 | RDMA/cm: Convert REQ SL fieldsdrivers/ drivers/ | +6 | 0 replies | |
| 32/48 | RDMA/cm: Convert REQ subnet local fieldsdrivers/ drivers/ | +5 | 0 replies | |
| 33/48 | RDMA/cm: Convert REQ local ack timeoutdrivers/ drivers/ | +9 | 0 replies | |
| 34/48 | RDMA/cm: Convert MRA MRAed fielddrivers/ drivers/ | +6 | 0 replies | |
| 35/48 | RDMA/cm: Convert MRA service timeoutdrivers/ drivers/ | +3 | 0 replies | |
| 36/48 | RDMA/cm: Update REJ struct to use new schemedrivers/ drivers/ | +9 | 0 replies | |
| 37/48 | RDMA/cm: Convert REP target ack delay fielddrivers/ drivers/ | +4 | 0 replies | |
| 38/48 | RDMA/cm: Convert REP failover accepted fielddrivers/ drivers/ | +2 | 0 replies | |
| 39/48 | RDMA/cm: Convert REP flow control fielddrivers/ drivers/ | +3 | 0 replies | |
| 40/48 | RDMA/cm: Convert REP RNR retry count fielddrivers/ drivers/ | +3 | 0 replies | |
| 41/48 | RDMA/cm: Convert REP SRQ fielddrivers/ drivers/ | +3 | 0 replies | |
| 42/48 | RDMA/cm: Delete unused CM LAP functionsdrivers/ drivers/ | +0 | 0 replies | |
| 43/48 | RDMA/cm: Convert LAP flow label fielddrivers/ drivers/ | +2 | 0 replies | |
| 44/48 | RDMA/cm: Convert LAP fieldsdrivers/ drivers/ | +5 | 0 replies | |
| 45/48 | RDMA/cm: Delete unused CM ARP functionsdrivers/ include/ | +0 | 0 replies | |
| 46/48 | RDMA/cm: Convert SIDR_REP to new schemedrivers/ drivers/ | +8 | 0 replies | |
| 47/48 | RDMA/cm: Add Enhanced Connection Establishment (ECE) bitsinclude/ include/ | +7 | 1 reply | |
| 48/48 | RDMA/cm: Convert private_date accessdrivers/ | +18 | 0 replies |
Reviews trailers per patch
1 of 48 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Bart Van Assche | Leon Romanovsky |
|---|---|---|
| Series | T-b R-b | |
| 1/48 | ||
| 2/48 | R-b | |
| 3/48 | ||
| 4/48 | ||
| 5/48 | ||
| 6/48 | ||
| 7/48 | ||
| 8/48 | ||
| 9/48 | ||
| 10/48 | ||
| 11/48 | ||
| 12/48 | ||
| 13/48 | ||
| 14/48 | ||
| 15/48 | ||
| 16/48 | ||
| 17/48 | ||
| 18/48 | ||
| 19/48 | ||
| 20/48 | ||
| 21/48 | ||
| 22/48 | ||
| 23/48 | ||
| 24/48 | ||
| 25/48 | ||
| 26/48 | ||
| 27/48 | ||
| 28/48 | ||
| 29/48 | ||
| 30/48 | ||
| 31/48 | ||
| 32/48 | ||
| 33/48 | ||
| 34/48 | ||
| 35/48 | ||
| 36/48 | ||
| 37/48 | ||
| 38/48 | ||
| 39/48 | ||
| 40/48 | ||
| 41/48 | ||
| 42/48 | ||
| 43/48 | ||
| 44/48 | ||
| 45/48 | ||
| 46/48 | ||
| 47/48 | ||
| 48/48 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH rdma-rc v2 00/48] Organize code according to IBTA layout
From: Leon Romanovsky <[email protected]>
Changelog:v1->v2: https://lore.kernel.org/linux-rdma/[email protected]
* Added forgotten CM_FIELD64_LOC().v0->v1: https://lore.kernel.org/linux-rdma/[email protected]
* Used Jason's macros as a basis for all get/set operation for wire protocol.
* Fixed wrong offsets.
* Grouped all CM related patches in one patchset bomb.
----------------------------------------------------------------------
Hi,
This series continues already started task to clean up CM related code.
Over the years, the IB/core gained a number of anti-patterns which led to mistakes. First and most distracting is spread of hardware specification types (e.g. __beXX) to the core logic. Second, endless copy/paste to access IBTA binary blobs, which made any IBTA extensions not an easy task.
In this series, we add Enhance Connection Establishment bits which were added recently to IBTA and will continue to convert rest of the CM code to propose macros by eliminating __beXX variables from core code.
All IBTA CM declarations are places into new header
file: include/rdma/ibta_vol1_c12.h and the idea that every spec chapter will have separate header file, so we will see immediately the relations between declarations and values.
Thanks
BTW,
1. The whole area near private_data looks sketchy to me and needs separate cleanup.
2. I know that it is more than 15 patches, but they are small and self-contained.
Leon Romanovsky (48):
RDMA/cm: Provide private data size to CM users
RDMA/srpt: Use private_data_len instead of hardcoded value RDMA/ucma: Mask QPN to be 24 bits according to IBTA RDMA/cm: Add SET/GET implementations to hide IBA wire format RDMA/cm: Request For Communication (REQ) message definitions RDMA/cm: Message Receipt Acknowledgment (MRA) message definitions RDMA/cm: Reject (REJ) message definitions
RDMA/cm: Reply To Request for communication (REP) definitions RDMA/cm: Ready To Use (RTU) definitions
RDMA/cm: Request For Communication Release (DREQ) definitions RDMA/cm: Reply To Request For Communication Release (DREP) definitions RDMA/cm: Load Alternate Path (LAP) definitions
RDMA/cm: Alternate Path Response (APR) message definitions RDMA/cm: Service ID Resolution Request (SIDR_REQ) definitions RDMA/cm: Service ID Resolution Response (SIDR_REP) definitions RDMA/cm: Convert QPN and EECN to be u32 variables
RDMA/cm: Convert REQ responded resources to the new scheme RDMA/cm: Convert REQ initiator depth to the new scheme RDMA/cm: Convert REQ remote response timeout
RDMA/cm: Simplify QP type to wire protocol translation RDMA/cm: Convert REQ flow control
RDMA/cm: Convert starting PSN to be u32 variable
RDMA/cm: Update REQ local response timeout
RDMA/cm: Convert REQ retry count to use new scheme RDMA/cm: Update REQ path MTU field
RDMA/cm: Convert REQ RNR retry timeout counter
RDMA/cm: Convert REQ MAX CM retries
RDMA/cm: Convert REQ SRQ field
RDMA/cm: Convert REQ flow label field
RDMA/cm: Convert REQ packet rate
RDMA/cm: Convert REQ SL fields
RDMA/cm: Convert REQ subnet local fields
RDMA/cm: Convert REQ local ack timeout
RDMA/cm: Convert MRA MRAed field
RDMA/cm: Convert MRA service timeout
RDMA/cm: Update REJ struct to use new scheme
RDMA/cm: Convert REP target ack delay field
RDMA/cm: Convert REP failover accepted field
RDMA/cm: Convert REP flow control field
RDMA/cm: Convert REP RNR retry count field
RDMA/cm: Convert REP SRQ field
RDMA/cm: Delete unused CM LAP functions
RDMA/cm: Convert LAP flow label field
RDMA/cm: Convert LAP fields
RDMA/cm: Delete unused CM ARP functions
RDMA/cm: Convert SIDR_REP to new scheme
RDMA/cm: Add Enhanced Connection Establishment (ECE) bits RDMA/cm: Convert private_date access
drivers/infiniband/core/cm.c | 554 ++++++++++-------------- drivers/infiniband/core/cm_msgs.h | 600 +------------------------- drivers/infiniband/core/cma.c | 11 +- drivers/infiniband/core/ucma.c | 2 +- drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- include/rdma/ib_cm.h | 55 +-- include/rdma/iba.h | 138 ++++++ include/rdma/ibta_vol1_c12.h | 211 +++++++++ 8 files changed, 599 insertions(+), 974 deletions(-) create mode 100644 include/rdma/iba.h create mode 100644 include/rdma/ibta_vol1_c12.h
--
2.20.1