Skip to content

drm/i915: eDP DPCD aux backlight fixes

Lyude Paul dri-devel intel-gfx lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v15 patches 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: Fix eDP DPCD aux max backlight calculationsdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c+95 -470 replies
2/5drm/i915: Assume 100% brightness when not in DPCD control modedrivers/gpu/drm/i915/display/intel_dp_aux_backlight.c+17 -00 replies
3/5drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight()drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c+2 -10 replies
4/5drm/i915: Don't use VBT for detecting DPCD backlight controlsdrivers/gpu/drm/i915/display/intel_dp_aux_backlight.c+10 -65 replies
5/5drm/i915: Auto detect DPCD backlight support by defaultdrivers/gpu/drm/i915/i915_params.c drivers/gpu/drm/i915/i915_params.h+2 -20 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchAceLan KaoPerry Yuan
1/5T-b T-b
2/5T-b T-b
3/5T-b T-b
4/5
5/5T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes

I recently got a ThinkPad X1 Extreme 2nd Generation for fixing some issues on, and noticed that out of the box the backlight doesn't work. Along the way of fixing that, I found a few issues with how i915 handles DPCD AUX backlight control and fixed them. Now I've got working backlight controls, hooray!

Note that this patch series enables DPCD backlight controls by default. This time however, we ignore the backlight type advertised in the VBT (unless it's a custom backlight interface that doesn't use the standard VESA interface over AUX) and just trust the DPCD.

Lyude Paul (5):
drm/i915: Fix eDP DPCD aux max backlight calculations drm/i915: Assume 100% brightness when not in DPCD control mode drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() drm/i915: Don't use VBT for detecting DPCD backlight controls drm/i915: Auto detect DPCD backlight support by default

 .../drm/i915/display/intel_display_types.h    |   3 +
 .../drm/i915/display/intel_dp_aux_backlight.c | 175 ++++++++++++------
 drivers/gpu/drm/i915/i915_params.c            |   2 +-
 drivers/gpu/drm/i915/i915_params.h            |   2 +-
 4 files changed, 126 insertions(+), 56 deletions(-)
Signature · 6 lines
2.24.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel