Skip to content

spidermonkey: new package.

aduskett at gmail.com buildroot 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v24 patches 0 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Applied Thomas' suggestions.
- Added dbus as a runtime dependency of polkit (polkitd will crash without it)
- Added an initrc S50polkit file.
- Added a polkit user (polkitd requires it.)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4spidermonkey: new packageDEVELOPERS package/Config.in package/spidermonkey/0001-allow-newer-autoconf-versions.patch +12 more+954 -01 reply
2/4package/polkit: bump to version 0.116DEVELOPERS package/polkit/0001-make-netgroup-support-optional.patch package/polkit/Config.in +4 more+298 -91 reply
3/4package/polkit: support different authentication frameworkspackage/polkit/polkit.mk+6 -20 replies
4/4package/polkit: enable systemd login supportpackage/polkit/polkit.mk+8 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Buildroot] [PATCH/next v3 0/4] spidermonkey: new package.

From: Adam Duskett <[email protected]>

Spidermonkey is Mozilla's JavaScript engine written in C and C++. It is used in various Mozilla products, including Firefox, and is available under the MPL2.

There are 19 patches currently required to properly cross-compile spidermonkey:

1) allow-newer-autoconf-versions
- Spidermonkey is hardcoded to use Autoconf 2.13, which is from 1999! The reasoning behind using 2.13 is because newer versions of Autoconf do not work correctly with the custom m4 macros in the source code.

However: Because we are building just the Spidermonkey engine instead of the entire Firefox package, newer versions of Autoconf work without issue.
See: See: https://bugzilla.mozilla.org/show_bug.cgi?id=104642
for further explanation.

2) allow-building-in-tree
- By default, spidermonkey must be configured and built out-of-tree, otherwise the following error occurs:

FATAL ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file or one of the files it includes:
js/src/shell/moz.build

The error occurred when validating the result of the execution. The reported error is:
The path specified in LOCAL_INCLUDES is not allowed:
.. (resolved to js/src)
Remove this check, as spidermonkey builds without issue in-tree.

3) allow-unknown-configuration-options
- By default, if an unknown parameter is passed to configure, an error is raised. Replace the raise with a pass and continue.
Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1379540

4) fix-building-with-musl
- The MIPS specific header <sgidefs.h> is not provided by musl. The Linux kernel headers <asm/sgidefs.h> provide the same definitions.

5) add-riscv-support
- Submitted upstream:

    See: https://bugzilla.mozilla.org/show_bug.cgi?id=1318905

6) copy-headers-on-install-instead-of-symlinking
- When installing, instead of linking the headers to the source directory, copy them.

7) ensure-proper-running-on-64-bit-and-32-bit-be-platforms
- Taken from the Fedora RPM

    Applied upstream.
    Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1488552

8) 0008-save-and-restore-non-volatile-x28-on-ARM64-for-generated-unboxed-obje
- Taken from the Fedora RPM:

    Applied upstream.
    Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1375074

9) save-x28-before-clobbering-it-in-the-regex-compiler
- Taken from the Fedora RPM:

    Applied upstream.
    Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1445907

10) always-use-the-equivalent-year-to-determine-the-time-zone
- Taken from the Fedora RPM:

    Applied upstream.
    Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1415202

Typically, The Firefox source tarball is used to build spidermonkey; however, this has two disadvantages:
- It's large. The Firefox source tarball is over 250M.
- It requires Autoconf 2.13
Instead, use a tarball with only the Spidermonkey source code in it with a pre-setup configure file. This tarball reduces the size to 31M and prevents the Autoconf 2.13 requirement.

Also in this patch set:
- Update polkit to 0.116
- Update polkit to support systemd-logind
- Update polkit to support linux-pam

Tested with test-pkg -a
- 44 tests completed:
- 18 OK
- 26 SKIPPED
- 0 FAILED

Changes from v1 -> v2:
- When making large patch series like this, I tend to do all of my work in my own fork of buildroot, and then copy the changes over to a master copy of buildroot. I was testing spidermonkey without host_python_ssl to make sure it's actually a requirement (It is), and I forgot to re-add it back before making the patch. Doh!

Changes from v2 -> v3:
- Applied Thomas' suggestions.
- Added dbus as a runtime dependency of polkit (polkitd will crash without it)
- Added an initrc S50polkit file.
- Added a polkit user (polkitd requires it.)

Adam Duskett (4):
spidermonkey: new package
package/polkit: bump to version 0.116 package/polkit: support different authentication frameworks package/polkit: enable systemd login support

 DEVELOPERS                                    |   2 +
 package/Config.in                             |   1 +
 .../0001-make-netgroup-support-optional.patch | 232 ++++++++++++++++++
 package/polkit/Config.in                      |  24 +-
 package/polkit/S50polkit                      |  16 ++
 package/polkit/polkit.hash                    |   2 +-
 package/polkit/polkit.mk                      |  39 ++-
 package/polkit/polkit.service                 |   7 +
 .../0001-allow-newer-autoconf-versions.patch  |  61 +++++
 .../0002-allow-building-in-tree.patch         |  47 ++++
 ...-allow-unknown-configuration-options.patch |  35 +++
 .../0004-fix-building-with-musl.patch         | 133 ++++++++++
 .../spidermonkey/0005-add-riscv-support.patch | 121 +++++++++
 ...ers-on-install-instead-of-symlinking.patch |  34 +++
 ...ng-on-64-bit-and-32-bit-be-platforms.patch | 144 +++++++++++
 ...-on-ARM64-for-generated-unboxed-obje.patch |  66 +++++
 ...-clobbering-it-in-the-regex-compiler.patch | 100 ++++++++
 ...lent-year-to-determine-the-time-zone.patch | 103 ++++++++
 package/spidermonkey/Config.in                |  47 ++++
 package/spidermonkey/spidermonkey.hash        |   3 +
 package/spidermonkey/spidermonkey.mk          |  58 +++++
 21 files changed, 1264 insertions(+), 11 deletions(-)
 create mode 100644 package/polkit/0001-make-netgroup-support-optional.patch
 create mode 100644 package/polkit/S50polkit
 create mode 100644 package/polkit/polkit.service
 create mode 100644 package/spidermonkey/0001-allow-newer-autoconf-versions.patch
 create mode 100644 package/spidermonkey/0002-allow-building-in-tree.patch
 create mode 100644 package/spidermonkey/0003-allow-unknown-configuration-options.patch
 create mode 100644 package/spidermonkey/0004-fix-building-with-musl.patch
 create mode 100644 package/spidermonkey/0005-add-riscv-support.patch
 create mode 100644 package/spidermonkey/0006-copy-headers-on-install-instead-of-symlinking.patch
 create mode 100644 package/spidermonkey/0007-ensure-proper-running-on-64-bit-and-32-bit-be-platforms.patch
 create mode 100644 package/spidermonkey/0008-save-and-restore-non-volatile-x28-on-ARM64-for-generated-unboxed-obje.patch
 create mode 100644 package/spidermonkey/0009-save-x28-before-clobbering-it-in-the-regex-compiler.patch
 create mode 100644 package/spidermonkey/0010-always-use-the-equivalent-year-to-determine-the-time-zone.patch
 create mode 100644 package/spidermonkey/Config.in
 create mode 100644 package/spidermonkey/spidermonkey.hash
 create mode 100644 package/spidermonkey/spidermonkey.mk
Signature · 1 line
2.23.0