Skip to content

pin_user_pages(): reduced-risk series for Linux 5.5

John Hubbard bpf dri-devel kvm linux-block linux-doc linux-fsdevel linux-kselftest linux-media linux-mm linux-rdma linuxppc-dev lkml netdev stable 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 2 repliesIn review
  2. v119 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* Fixed up ppc in response to Jan Kara's review comments (thanks for those!).

* Fixed a kbuilt robot-detected build failure: added a stub function for the !CONFIG_MMU case.

* Cover letter: now refers to "unpin_user_page()", reflecting the name change in the last patch (instead of put_user_page() ).

* Rebased onto today's linux-next: c165016bac27 ("Add linux-next specific files for 20191125")

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19mm/gup: factor out duplicate code from four routinesmm/gup.c+36 -550 replies
2/19mm/gup: move try_get_compound_head() to top, fix minor issuesmm/gup.c+15 -140 replies
3/19mm: Cleanup __put_devmap_managed_page() vs ->page_free()drivers/nvdimm/pmem.c mm/memremap.c+44 -420 replies
4/19goldish_pipe: rename local pin_user_pages() routinedrivers/platform/goldfish/goldfish_pipe.c+9 -90 replies
5/19mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERMmm/gup.c+22 -50 replies
6/19vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() calldrivers/vfio/vfio_iommu_type1.c+5 -250 replies
7/19mm/gup: introduce pin_user_pages*() and FOLL_PINDocumentation/core-api/index.rst Documentation/core-api/pin_user_pages.rst include/linux/mm.h +1 more+424 -340 replies
8/19goldish_pipe: convert to pin_user_pages() and put_user_page()drivers/platform/goldfish/goldfish_pipe.c+3 -140 replies
9/19IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODPdrivers/infiniband/core/umem.c drivers/infiniband/core/umem_odp.c drivers/infiniband/hw/hfi1/user_pages.c +5 more+13 -140 replies
10/19mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote()mm/process_vm_access.c+15 -130 replies
11/19drm/via: set FOLL_PIN via pin_user_pages_fast()drivers/gpu/drm/via/via_dmablit.c+1 -10 replies
12/19fs/io_uring: set FOLL_PIN via pin_user_pages()fs/io_uring.c+1 -10 replies
13/19net/xdp: set FOLL_PIN via pin_user_pages()net/xdp/xdp_umem.c+1 -10 replies
14/19media/v4l2-core: set pages dirty upon releasing DMA buffersdrivers/media/v4l2-core/videobuf-dma-sg.c+4 -10 replies
15/19media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversiondrivers/media/v4l2-core/videobuf-dma-sg.c+4 -70 replies
16/19vfio, mm: pin_user_pages (FOLL_PIN) and put_user_page() conversiondrivers/vfio/vfio_iommu_type1.c+3 -40 replies
17/19powerpc: book3s64: convert to pin_user_pages() and put_user_page()arch/powerpc/mm/book3s64/iommu_api.c+5 -72 replies
18/19mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1"mm/gup_benchmark.c tools/testing/selftests/vm/gup_benchmark.c+11 -40 replies
19/19mm, tree-wide: rename put_user_page*() to unpin_user_page*()Documentation/core-api/pin_user_pages.rst arch/powerpc/mm/book3s64/iommu_api.c drivers/gpu/drm/via/via_dmablit.c +15 more+55 -550 replies

Reviews trailers per patch

18 of 19 patches have a Reviewed-by or Acked-by.

PatchJens AxboeJan KaraAlex WilliamsonIra WeinyChristoph HellwigJérôme GlisseJason GunthorpeMike RapoportDaniel VetterBjörn TöpelHans Verkuil
1/19R-b R-b R-b
2/19R-b R-b R-b
3/19R-b R-b
4/19R-b R-b R-b
5/19T-b A-b R-b R-b
6/19T-b A-b R-b R-b
7/19R-b R-b R-b
8/19R-b R-b
9/19R-b
10/19R-b R-b R-b
11/19R-b R-b A-b
12/19R-b R-b
13/19A-b
14/19R-b A-b
15/19A-b
16/19T-b A-b
17/19
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/19] pin_user_pages(): reduced-risk series for Linux 5.5

Hi,

Changes since v1:

* Fixed up ppc in response to Jan Kara's review comments (thanks for those!).

* Fixed a kbuilt robot-detected build failure: added a stub function for the !CONFIG_MMU case.

* Cover letter: now refers to "unpin_user_page()", reflecting the name change in the last patch (instead of put_user_page() ).

* Rebased onto today's linux-next: c165016bac27 ("Add linux-next specific files for 20191125")

========================================================================
Here is a set of well-reviewed (expect for one patch), lower-risk items that can go into Linux 5.5. (Update: the powerpc conversion patch has had some initial review now, since v1 was posted.)

This is essentially a cut-down v8 of "mm/gup: track dma-pinned pages:
FOLL_PIN" [1], and with one of the VFIO patches split into two patches. The idea here is to get this long list of "noise" checked into 5.5, so that the actual, higher-risk "track FOLL_PIN pages" (which is deferred:
not part of this series) will be a much shorter patchset to review.

For the v4l2-core changes, I've left those here (instead of sending them separately to the -media tree), in order to get the name change done now (put_user_page --> unpin_user_page). However, I've added a Cc stable, as recommended during the last round of reviews.

Here are the relevant notes from the original cover letter, edited to match the current situation:

This is a prerequisite to tracking dma-pinned pages. That in turn is a prerequisite to solving the larger problem of proper interactions between file-backed pages, and [R]DMA activities, as discussed in [1], [2], [3], and in a remarkable number of email threads since about 2017. :)

A new internal gup flag, FOLL_PIN is introduced, and thoroughly documented in the last patch's Documentation/vm/pin_user_pages.rst.

I believe that this will provide a good starting point for doing the layout lease work that Ira Weiny has been working on. That's because these new wrapper functions provide a clean, constrained, systematically named set of functionality that, again, is required in order to even know if a page is "dma-pinned".

In contrast to earlier approaches, the page tracking can be incrementally applied to the kernel call sites that, until now, have been simply calling get_user_pages() ("gup"). In other words, opt-in by changing from this:

get_user_pages() (sets FOLL_GET)
put_page()

to this:
pin_user_pages() (sets FOLL_PIN)
unpin_user_page()

Because there are interdependencies with FOLL_LONGTERM, a similar conversion as for FOLL_PIN, was applied. The change was from this:

get_user_pages(FOLL_LONGTERM) (also sets FOLL_GET) put_page()

to this:
pin_longterm_pages() (sets FOLL_PIN | FOLL_LONGTERM) unpin_user_page()

[1] https://lore.kernel.org/r/[email protected]

thanks,
John Hubbard
NVIDIA

Dan Williams (1):
mm: Cleanup __put_devmap_managed_page() vs ->page_free()

John Hubbard (18):
mm/gup: factor out duplicate code from four routines mm/gup: move try_get_compound_head() to top, fix minor issues
goldish_pipe: rename local pin_user_pages() routine
mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERM
vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call mm/gup: introduce pin_user_pages*() and FOLL_PIN
goldish_pipe: convert to pin_user_pages() and put_user_page() IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() drm/via: set FOLL_PIN via pin_user_pages_fast() fs/io_uring: set FOLL_PIN via pin_user_pages()
net/xdp: set FOLL_PIN via pin_user_pages() media/v4l2-core: set pages dirty upon releasing DMA buffers media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page()
conversion
vfio, mm: pin_user_pages (FOLL_PIN) and put_user_page() conversion
powerpc: book3s64: convert to pin_user_pages() and put_user_page() mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding

    "1"

mm, tree-wide: rename put_user_page*() to unpin_user_page*()

 Documentation/core-api/index.rst            |   1 +
 Documentation/core-api/pin_user_pages.rst   | 233 ++++++++++++++
 arch/powerpc/mm/book3s64/iommu_api.c        |  12 +-
 drivers/gpu/drm/via/via_dmablit.c           |   6 +-
 drivers/infiniband/core/umem.c              |   4 +-
 drivers/infiniband/core/umem_odp.c          |  13 +-
 drivers/infiniband/hw/hfi1/user_pages.c     |   4 +-
 drivers/infiniband/hw/mthca/mthca_memfree.c |   8 +-
 drivers/infiniband/hw/qib/qib_user_pages.c  |   4 +-
 drivers/infiniband/hw/qib/qib_user_sdma.c   |   8 +-
 drivers/infiniband/hw/usnic/usnic_uiom.c    |   4 +-
 drivers/infiniband/sw/siw/siw_mem.c         |   4 +-
 drivers/media/v4l2-core/videobuf-dma-sg.c   |   8 +-
 drivers/nvdimm/pmem.c                       |   6 -
 drivers/platform/goldfish/goldfish_pipe.c   |  35 +-
 drivers/vfio/vfio_iommu_type1.c             |  35 +-
 fs/io_uring.c                               |   6 +-
 include/linux/mm.h                          |  77 +++--
 mm/gup.c                                    | 340 +++++++++++++-------
 mm/gup_benchmark.c                          |   9 +-
 mm/memremap.c                               |  80 ++---
 mm/process_vm_access.c                      |  28 +-
 net/xdp/xdp_umem.c                          |   4 +-
 tools/testing/selftests/vm/gup_benchmark.c  |   6 +-
 24 files changed, 650 insertions(+), 285 deletions(-)
 create mode 100644 Documentation/core-api/pin_user_pages.rst
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel