Skip to content

usb: host: xhci-tegra: Implement basic ELPG support

Thierry Reding linux-usb 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 0 repliesNew
  2. v110 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- add Reviewed-by from JC on the one patch that is not originally his
- remove some useless gotos as pointed out by Mathias

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10usb: host: xhci-tegra: Fix "tega" -> "tegra" typodrivers/usb/host/xhci-tegra.c+2 -20 replies
2/10usb: host: xhci-tegra: Separate firmware request and loaddrivers/usb/host/xhci-tegra.c+30 -100 replies
3/10usb: host: xhci-tegra: Avoid a fixed duration sleepdrivers/usb/host/xhci-tegra.c+14 -10 replies
4/10usb: host: xhci-tegra: Use CNR as firmware ready indicatordrivers/usb/host/xhci-tegra.c+15 -120 replies
5/10usb: host: xhci-tegra: Extract firmware enable helperdrivers/usb/host/xhci-tegra.c+29 -120 replies
6/10usb: host: xhci-tegra: Reuse stored register base addressdrivers/usb/host/xhci-tegra.c+8 -80 replies
7/10usb: host: xhci-tegra: Enable runtime PM as late as possibledrivers/usb/host/xhci-tegra.c+17 -160 replies
8/10usb: host: xhci-tegra: Add support for XUSB context save/restoredrivers/usb/host/xhci-tegra.c+100 -20 replies
9/10usb: host: xhci-tegra: Add XUSB controller contextdrivers/usb/host/xhci-tegra.c+69 -110 replies
10/10usb: host: xhci-tegra: Implement basic ELPG supportdrivers/usb/host/xhci-tegra.c+119 -80 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchJC Kuo
1/10R-b
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] usb: host: xhci-tegra: Implement basic ELPG support

From: Thierry Reding <[email protected]>

Hi,

this series of patches is an attempt to split up JC's large patch adding ELPG support into more manageable chunks. The original patch can be found here:

        http://patchwork.ozlabs.org/patch/1115804/

That patch was part of a larger series that also added a couple more features to more aggressively save power. This series is more limited in scope and at the same time tries to address most of the comments that were voiced during review of JC's original posting.

Note that this series is primarily targetted at getting system suspend and resume to work properly on Jetson TX2 and later, now that we can actually resume from system sleep on these systems. The code should also work on Tegra210 and earlier, though Tegra210 is still missing a bit of the very low-level plumbing to make the system resume properly from sleep.

I've verified that after this I can successfully use the XHCI on Jetson TX2 after a system suspend/resume cycle.

Note that I've claimed ownership of these patches because they differ from JC's patches significantly in many areas and are also a bit crippled compared to JC's original in terms of features. I've credited JC in the commit message, but didn't want him to get any blame from me potentially messing this up.

JC, if you think this is still in line with what you had in mind, let me know and I'll restore your authorship.

Changes in v2:
- add Reviewed-by from JC on the one patch that is not originally his
- remove some useless gotos as pointed out by Mathias

Thierry

Thierry Reding (10):
usb: host: xhci-tegra: Fix "tega" -> "tegra" typo
usb: host: xhci-tegra: Separate firmware request and load
usb: host: xhci-tegra: Avoid a fixed duration sleep
usb: host: xhci-tegra: Use CNR as firmware ready indicator
usb: host: xhci-tegra: Extract firmware enable helper
usb: host: xhci-tegra: Reuse stored register base address
usb: host: xhci-tegra: Enable runtime PM as late as possible
usb: host: xhci-tegra: Add support for XUSB context save/restore
usb: host: xhci-tegra: Add XUSB controller context
usb: host: xhci-tegra: Implement basic ELPG support

 drivers/usb/host/xhci-tegra.c | 439 +++++++++++++++++++++++++++++-----
 1 file changed, 380 insertions(+), 59 deletions(-)
Signature · 1 line
2.23.0