Skip to content

net: mscc: ocelot: fix potential issues accessing skbs list

Yangbo Lu netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v11 patch 3 repliesSuperseded

Changes in v2 from the cover letter

- Split into two patches.
- Converted to use skb queue.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: mscc: ocelot: avoid incorrect consuming in skbs listdrivers/net/ethernet/mscc/ocelot.c+1 -00 replies
2/2net: mscc: ocelot: use skb queue instead of skbs listdrivers/net/ethernet/mscc/ocelot.c include/soc/mscc/ocelot.h+19 -440 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [v2, 0/2] net: mscc: ocelot: fix potential issues accessing skbs list

Fix two prtential issues accessing skbs list.
- Break the matching loop when find the matching skb to avoid consuming more skbs incorrectly. The timestamp ID is only from 0 to 3 while the FIFO supports 128 timestamps at most.
- Convert to use skb queue instead of the list of skbs to provide protect with lock.

---
Changes for v2:
- Split into two patches.
- Converted to use skb queue.

Yangbo Lu (2):
net: mscc: ocelot: avoid incorrect consuming in skbs list
net: mscc: ocelot: use skb queue instead of skbs list

 drivers/net/ethernet/mscc/ocelot.c | 55 +++++++++++++-------------------------
 include/soc/mscc/ocelot.h          |  9 +------
 2 files changed, 20 insertions(+), 44 deletions(-)
Signature · 1 line
2.7.4