drm/udl: Convert to simple-pipe helpers and clean up
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 0 repliesNew
- v29 patches 2 repliesSuperseded
- v17 patches 10 repliesSuperseded
Changes in v3 from the cover letter
* use symbolic names for blanking ops
* cosmetic changes
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | drm/udl: Init connector before encoder and CRTCdrivers/ drivers/ drivers/ | +18 | 0 replies | |
| 2/9 | drm/udl: Convert to struct drm_simple_display_pipedrivers/ drivers/ drivers/ +3 more | +86 | 0 replies | |
| 3/9 | drm/udl: Switch to atomic suspend/resume helpersdrivers/ drivers/ drivers/ | +2 | 0 replies | |
| 4/9 | drm/udl: Inline DPMS code into CRTC enable and disable functionsdrivers/ drivers/ | +38 | 0 replies | |
| 5/9 | drm/udl: Set preferred color depth to 16 bppdrivers/ drivers/ | +2 | 0 replies | |
| 6/9 | drm/udl: Convert to drm_atomic_helper_dirtyfb()drivers/ drivers/ drivers/ | +8 | 0 replies | |
| 7/9 | drm/udl: Remove struct udl_device.active_fb_16drivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 8/9 | drm/udl: Move udl_handle_damage() into udl_modeset.cdrivers/ drivers/ drivers/ | +111 | 0 replies | |
| 9/9 | drm/udl: Remove udl_fb.cdrivers/ drivers/ | +1 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Vetter | Emil Velikov |
|---|---|---|
| 1/9 | R-b | R-b |
| 2/9 | R-b | |
| 3/9 | R-b | |
| 4/9 | R-b | |
| 5/9 | R-b | |
| 6/9 | R-b | R-b |
| 7/9 | R-b | R-b |
| 8/9 | R-b | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/9] drm/udl: Convert to simple-pipe helpers and clean up
With only a single display pipeline and primary plane, udl is perfect for simple-pipe helpers. Patches 1 to 4 do the convertion. This enables atomic modesetting for udl devices.
Patches 5 to 8 clean up handling of color depth and framebuffers. With universal planes that come with simple pipe, display updates can be implemented with DRM's damage handlers. The primary plane's formats array allows to export the correct preferred color depth. The original value was choosen for maximum compatibility, but did not represent the device's capability.
Patch 9 removes udl's remaining, unused fb code.
The patchset has been tested by running the fb console, X11 and Weston on a DisplayLink adapter. Posting v3 for (hopefully) final comments.
v3:
* use symbolic names for blanking ops
* cosmetic changes
v2:
* rebased on the recent udl damage-handler patchset
* moved atomic suspend/resume conversion into separate patch
* don't call drm_connector_{register,unregister}()
Thomas Zimmermann (9):
drm/udl: Init connector before encoder and CRTC drm/udl: Convert to struct drm_simple_display_pipe drm/udl: Switch to atomic suspend/resume helpers drm/udl: Inline DPMS code into CRTC enable and disable functions drm/udl: Set preferred color depth to 16 bpp
drm/udl: Convert to drm_atomic_helper_dirtyfb() drm/udl: Remove struct udl_device.active_fb_16 drm/udl: Move udl_handle_damage() into udl_modeset.c drm/udl: Remove udl_fb.c
drivers/gpu/drm/udl/Makefile | 2 +- drivers/gpu/drm/udl/udl_connector.c | 21 +- drivers/gpu/drm/udl/udl_drv.c | 11 +- drivers/gpu/drm/udl/udl_drv.h | 29 +-- drivers/gpu/drm/udl/udl_encoder.c | 70 ------ drivers/gpu/drm/udl/udl_fb.c | 222 ----------------- drivers/gpu/drm/udl/udl_main.c | 3 - drivers/gpu/drm/udl/udl_modeset.c | 369 ++++++++++++++++------------ 8 files changed, 238 insertions(+), 489 deletions(-) delete mode 100644 drivers/gpu/drm/udl/udl_encoder.c delete mode 100644 drivers/gpu/drm/udl/udl_fb.c
--
2.24.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel