Skip to content

Add support for booting EFI FIT images

Cristian Ciocaltea u-boot 1 version New

Get series with b4
b4 am 20191127194526.GA18254@BV030612LT

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] Add support for booting EFI FIT images
Quoted 59 lines · Heinrich Schuchardt
Quoted 40 lines · Cristian Ciocaltea

Currently the only way to run an EFI binary like GRUB2 is via the 'bootefi' command, which cannot be used in a verified boot scenario.

The obvious solution to this limitation is to add support for booting FIT images containing those EFI binaries.

The implementation relies on a new image type - IH_OS_EFI - which can be created by using 'os = "efi"' inside an ITS file:

/ {
     #address-cells = <1>;

     images {
         efi-grub {
             description = "GRUB EFI";
             data = /incbin/("EFI/BOOT/bootarm.efi");
             type = "kernel_noload";
             arch = "arm";
             os = "efi";
             compression = "none";
             load = <0x0>;
             entry = <0x0>;
             hash-1 {
                 algo = "sha256";
             };
         };
     };

     configurations {
         default = "config-grub";
         config-grub {
             kernel = "efi-grub";
             signature-1 {
                 algo = "sha256,rsa2048";
                 sign-images = "kernel";
             };
         };
     };
};
Quoted 8 lines

The bootm command has been extended to handle the IH_OS_EFI images. To enable this feature, a new configuration option has been added:
BOOTM_EFI

I tested the solution using the 'qemu_arm' board:

=> load scsi 0:1 ${kernel_addr_r} efi-image.fit
=> bootm ${kernel_addr_r}#config-grub

Thanks a lot for the patch series which makes good sense to me.

I think we should pass addresses and not strings to cmd/bootefi.c. This will need a bit of refactoring as already addressed in a comment to patch 2/2.

Additionally the documentation in doc/uefi/u-boot_on_efi.rst and doc/uImage.FIT/howto.txt should be updated.

Quoted 7 lines

I cc the contributors given by
scripts/get_maintainer.pl -f common/bootm_os.c

Best regards

Heinrich

Thanks for the feedback, Heinrich!

Instead of creating new function(s), I think we could simply extend
int do_bootefi_image(const char *image_opt)
with a new parameter to hold the fdt address and move here the call to 'efi_install_fdt()', which is now performed by 'do_bootefi()'.

However, I'm not sure about changing the data types, i.e. from 'char *' to ulong, for the following reasons:
1. image_opt may have a different meaning in addition to efi address
2. fdt address may not be provided, so we need somehow to detect an invalid value

Kind regards,
Cristian

Quoted 16 lines
Quoted 15 lines

Cristian Ciocaltea (2):
image: Add IH_OS_EFI for EFI chain-load boot
bootm: Add a bootm command for type IH_OS_EFI

  cmd/Kconfig        |  9 ++++++++-
  cmd/bootefi.c      |  2 +-
  common/bootm_os.c  | 44 ++++++++++++++++++++++++++++++++++++++++++++
  common/image-fit.c |  3 ++-
  common/image.c     |  1 +
  include/bootm.h    |  2 ++
  include/image.h    |  1 +
  7 files changed, 59 insertions(+), 3 deletions(-)