Skip to content

grep: don't return an expression from pcre2_free()

Hans Jerry Illikainen git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1grep: don't return an expression from pcre2_free()grep.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] grep: don't return an expression from pcre2_free()

This is a simple one-line fix for a bug I ran into when enabling pedantic builds with DEVELOPER=1 and --with-libpcre. Previously, the void function pcre2_free() returned an expression. This commit changes that as per section 6.8.6.4 in C99 [1] and C11 [2]:

Quoted 2 lines

A return statement with an expression shall not appear in a function whose return type is void.

[1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf
[2] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1548.pdf

Hans Jerry Illikainen (1):
grep: don't return an expression from pcre2_free()

 grep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.24.0.156.g00c62833a5