Skip to content

selftests/powerpc: A few fixes on powerpc selftests

Desnes A. Nunes do Rosario linuxppc-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/23 patches 3 repliesIn review
  2. v1 posting 1/21 patch 0 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests/powerpc: Use write_pmc instead of count_pmc to reset PMCs on ebb teststools/testing/selftests/powerpc/pmu/ebb/back_to_back_ebbs_test.c tools/testing/selftests/powerpc/pmu/ebb/cycles_test.c tools/testing/selftests/powerpc/pmu/ebb/cycles_with_freeze_test.c +8 more+16 -161 reply
2/3selftests/powerpc: enable performance alerts when freezing counters on cycles_with_freeze_test selftesttools/testing/selftests/powerpc/pmu/ebb/cycles_with_freeze_test.c+1 -11 reply
3/3selftests/powerpc: ensure PMC reads are set and ordered on count_pmctools/testing/selftests/powerpc/pmu/ebb/ebb.c+4 -01 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRashmica Gupta
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH, RESEND, 0/3] selftests/powerpc: A few fixes on powerpc selftests

This patchseries addresses a few fixes on powerpc selftests (first and second patch are being resent).

The first fix has to do with the extra counts on PMCs resets, which not only are shown on the trace_logs, but can also invalidate the results of a few selftests. On the other hand, the second fix proper addresses the Per- formance Monitor Alert (PMAE) bit on MMCR0 when freezing counters are dis- abled on cycles_with_freeze_test selftest. Lastly, the third fix adds a memory barrier on count_pmc() to ensure read consistency of PMCs. This is necessary since these values are usually accounted on ebb_handlers to val- lidade tests results, such as the overflow values on pmc56_overflow_test.

Desnes A. Nunes do Rosario (2):
selftests/powerpc: Use write_pmc instead of count_pmc to reset PMCs on
ebb tests
selftests/powerpc: ensure PMC reads are set and ordered on count_pmc

Gustavo Romero (1):
selftests/powerpc: enable performance alerts when freezing counters on
cycles_with_freeze_test selftest

 .../powerpc/pmu/ebb/back_to_back_ebbs_test.c         |  2 +-
 .../testing/selftests/powerpc/pmu/ebb/cycles_test.c  |  2 +-
 .../powerpc/pmu/ebb/cycles_with_freeze_test.c        |  4 ++--
 .../powerpc/pmu/ebb/cycles_with_mmcr2_test.c         |  2 +-
 tools/testing/selftests/powerpc/pmu/ebb/ebb.c        |  6 +++++-
 .../powerpc/pmu/ebb/ebb_on_willing_child_test.c      |  2 +-
 .../selftests/powerpc/pmu/ebb/lost_exception_test.c  |  2 +-
 .../selftests/powerpc/pmu/ebb/multi_counter_test.c   | 12 ++++++------
 .../selftests/powerpc/pmu/ebb/multi_ebb_procs_test.c |  2 +-
 .../selftests/powerpc/pmu/ebb/pmae_handling_test.c   |  2 +-
 .../selftests/powerpc/pmu/ebb/pmc56_overflow_test.c  |  2 +-
 11 files changed, 21 insertions(+), 17 deletions(-)
Signature · 1 line
2.21.1