rsi: fix use-after-free, memleak and sleep-while-atomic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rsi: fix use-after-free on failed probe and unbinddrivers/ | +17 | 1 reply | |
| 2/5 | rsi: fix use-after-free on probe errorsdrivers/ | +6 | 0 replies | |
| 3/5 | rsi: fix memory leak on failed URB submissiondrivers/ | +3 | 0 replies | |
| 4/5 | rsi: fix non-atomic allocation in completion handlerdrivers/ | +7 | 0 replies | |
| 5/5 | rsi: add missing endpoint sanity checksdrivers/ | +10 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] rsi: fix use-after-free, memleak and sleep-while-atomic
The syzbot fuzzer has reported two separate use-after-free issues, which are fixed by the first two patches.
Turns out there were more gems in this driver and the next two patches fixes a memory leak and a potential sleep-while-atomic found through inspection.
The last one tightens the seemingly broken endpoint sanity check which would have the driver try to submit a bulk URB to the default pipe (and fail).
Tested using a mockup device.
Johan
Johan Hovold (5):
rsi: fix use-after-free on failed probe and unbind
rsi: fix use-after-free on probe errors
rsi: fix memory leak on failed URB submission
rsi: fix non-atomic allocation in completion handler
rsi: add missing endpoint sanity checks
drivers/net/wireless/rsi/rsi_91x_hal.c | 12 +++---- drivers/net/wireless/rsi/rsi_91x_usb.c | 47 ++++++++++++++++++++------ 2 files changed, 43 insertions(+), 16 deletions(-)
Signature · 1 line
2.24.0