Skip to content

s390x: Protected Virtualization support

Janosch Frank qemu-devel 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest16 patches 11 repliesIn review
  2. v1016 patches 22 repliesSuperseded
  3. v915 patches 69 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v815 patches11 repliesSuperseded
v715 patches15 repliesSuperseded
v618 patches53 repliesApplied
v518 patches36 repliesSuperseded
v416 patches15 repliesSuperseded
v3 posting 2/217 patches22 repliesApplied
v3 posting 1/24 patches21 repliesApplied
v23 patches6 repliesSuperseded
v13 patches7 repliesApplied

Changes in v11 from the cover letter

* Review fixes

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16s390x: Move diagnose 308 subcodes and rcs into ipl.hhw/s390x/ipl.h target/s390x/diag.c+11 -111 reply
2/16Sync pvlinux-headers/linux/kvm.h+43 -20 replies
3/16s390x: protvirt: Support unpack facilityMAINTAINERS hw/s390x/Makefile.objs hw/s390x/ipl.c +11 more+468 -106 replies
4/16s390x: protvirt: Add migration blockerhw/s390x/s390-virtio-ccw.c+18 -00 replies
5/16s390x: protvirt: Inhibit balloon when switching to protected modehw/s390x/s390-virtio-ccw.c+11 -00 replies
6/16s390x: protvirt: KVM intercept changestarget/s390x/kvm.c+4 -00 replies
7/16s390x: Add SIDA memory opstarget/s390x/cpu.h target/s390x/kvm.c target/s390x/kvm_s390x.h +1 more+48 -10 replies
8/16s390x: protvirt: Move STSI data over SIDADtarget/s390x/kvm.c+9 -20 replies
9/16s390x: protvirt: SCLP interpretationhw/s390x/sclp.c include/hw/s390x/sclp.h target/s390x/kvm.c+67 -161 reply
10/16s390x: protvirt: Set guest IPL PSWtarget/s390x/cpu.c+17 -94 replies
11/16s390x: protvirt: Move diag 308 data over SIDAtarget/s390x/diag.c+21 -60 replies
12/16s390x: protvirt: Disable address checks for PV guest IO emulationtarget/s390x/ioinst.c+28 -70 replies
13/16s390x: protvirt: Move IO control structures over SIDAtarget/s390x/ioinst.c+45 -160 replies
14/16s390x: protvirt: Handle SIGP store status correctlytarget/s390x/helper.c+6 -00 replies
15/16docs: system: Add protvirt docsdocs/system/s390x/protvirt.rst docs/system/target-s390x.rst+65 -00 replies
16/16s390x: Add unpack facility feature to GA1target/s390x/gen-features.c target/s390x/kvm.c+9 -00 replies

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckChristian BorntraegerDavid HildenbrandClaudio ImbrendaThomas Huth
1/16R-b R-b R-b
2/16
3/16R-b R-b R-b R-b R-b R-b
4/16R-b R-b R-b R-b
5/16R-b R-b R-b R-b
6/16R-b R-b R-b R-b
7/16R-b R-b R-b R-b
8/16R-b R-b R-b
9/16R-b R-b R-b R-b
10/16R-b R-b R-b R-b R-b
11/16R-b R-b R-b R-b
12/16R-b R-b R-b R-b R-b
13/16R-b R-b
14/16R-b R-b R-b R-b R-b
15/16R-b A-b A-b R-b
16/16R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v11 thread

Cover letter [PATCH v11 00/16] s390x: Protected Virtualization support

Most of the QEMU changes for PV are related to the new IPL type with subcodes 8 - 10 and the execution of the necessary Ultravisor calls to IPL secure guests. Note that we can only boot into secure mode from normal mode, i.e. stfle 161 is not active in secure mode.

The other changes related to data gathering for emulation and disabling addressing checks in secure mode, as well as CPU resets.

v11:
* Review fixes

v10:
* Moved documentation into subfolder
* Added huge page fencing
* Cleared up IO questions that were remaining
* Added exits/abbort/assert for conditions where we can't recover

v9:
* Moved pv.h into include/hw/s390x/
* Replaced cmd strings with macro
* Moved s390_is_pv() to pv.h
* Added new copyright dates and authors
v8:
* Removed the iplb_valid changes as they are picked
* Checkpatch fixes
* Review fixes
* Replaced env/ms->pv with s390_is_pv()
v7:
* Merged the diag 308 subcode patches and the unpack
* Moved the SIDA memops into the sync patch
* Bailout for the none machien and fencing of CONFIG_USER_ONLY
* Changes due to review

v6:
* diag308 rc numbers were changed by architecture
* IPL pv block received one more reserved field by architecture
* Officially added the bios patch to the series
* Dropped picked constant rename patch

v5:
* Moved docs into docs/system
* Some more enable/disable changes
* Moved enablement/disablement of pv in separate functions
* Some review fixes

v4:
* Sync with KVM changes
* Review changes

V3:
* Use dedicated functions to access SIDA
* Smaller cleanups and segfault fixes
* Error reporting for Ultravisor calls
* Inject of RC of diag308 subcode 10 fails

V2:
* Split out cleanups
* Internal PV state tracking
* Review feedback

Christian Borntraeger (1):
s390x: Add unpack facility feature to GA1

Janosch Frank (15):
s390x: Move diagnose 308 subcodes and rcs into ipl.h Sync pv
s390x: protvirt: Support unpack facility
s390x: protvirt: Add migration blocker
s390x: protvirt: Inhibit balloon when switching to protected mode
s390x: protvirt: KVM intercept changes
s390x: Add SIDA memory ops
s390x: protvirt: Move STSI data over SIDAD
s390x: protvirt: SCLP interpretation
s390x: protvirt: Set guest IPL PSW
s390x: protvirt: Move diag 308 data over SIDA
s390x: protvirt: Disable address checks for PV guest IO emulation
s390x: protvirt: Move IO control structures over SIDA
s390x: protvirt: Handle SIGP store status correctly
docs: system: Add protvirt docs

 MAINTAINERS                         |   2 +
 docs/system/s390x/protvirt.rst      |  60 +++++++++++
 docs/system/target-s390x.rst        |   5 +
 hw/s390x/Makefile.objs              |   1 +
 hw/s390x/ipl.c                      |  59 ++++++++++-
 hw/s390x/ipl.h                      | 102 ++++++++++++++++++-
 hw/s390x/pv.c                       |  98 ++++++++++++++++++
 hw/s390x/s390-virtio-ccw.c          | 148 +++++++++++++++++++++++++++-
 hw/s390x/sclp.c                     |  56 ++++++++---
 include/hw/s390x/pv.h               |  55 +++++++++++
 include/hw/s390x/s390-virtio-ccw.h  |   1 +
 include/hw/s390x/sclp.h             |   2 +
 linux-headers/linux/kvm.h           |  45 ++++++++-
 target/s390x/cpu.c                  |  27 +++--
 target/s390x/cpu.h                  |   7 +-
 target/s390x/cpu_features_def.inc.h |   1 +
 target/s390x/diag.c                 |  77 +++++++++++----
 target/s390x/gen-features.c         |   1 +
 target/s390x/helper.c               |   6 ++
 target/s390x/ioinst.c               |  96 +++++++++++++-----
 target/s390x/kvm-stub.c             |   5 +
 target/s390x/kvm.c                  |  79 +++++++++++++--
 target/s390x/kvm_s390x.h            |   3 +
 target/s390x/mmu_helper.c           |  14 +++
 24 files changed, 870 insertions(+), 80 deletions(-)
 create mode 100644 docs/system/s390x/protvirt.rst
 create mode 100644 hw/s390x/pv.c
 create mode 100644 include/hw/s390x/pv.h
Signature · 1 line
2.25.1