Skip to content

Error handling fixes, may contain 4.2 material

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 52 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21net/virtio: Drop useless n->primary_dev not null checkshw/net/virtio-net.c+1 -71 reply
2/21net/virtio: Fix failover error handling crash bugshw/net/virtio-net.c+13 -61 reply
3/21block/file-posix: Fix laio_init() error handling crash bugblock/file-posix.c+1 -12 replies
4/21crypto: Fix certificate file error handling crash bugcrypto/tlscredsx509.c+1 -11 reply
5/21crypto: Fix typo in QCryptoTLSSession's <example> commentinclude/crypto/tlssession.h+1 -11 reply
6/21io: Fix Error usage in a comment <example>include/io/task.h+1 -12 replies
7/21tests: Clean up initialization of Error *err variablestests/test-qobject-output-visitor.c tests/test-string-output-visitor.c+6 -61 reply
8/21exec: Fix latent file_ram_alloc() error handling bugexec.c+4 -21 reply
9/21hw/acpi: Fix latent legacy CPU plug error handling bughw/acpi/cpu_hotplug.c+3 -71 reply
10/21hw/core: Fix latent fit_load_fdt() error handling bughw/core/loader-fit.c+8 -75 replies
11/21hw/ipmi: Fix latent realize() error handling bugshw/ipmi/isa_ipmi_bt.c hw/ipmi/isa_ipmi_kcs.c hw/ipmi/pci_ipmi_bt.c +1 more+18 -84 replies
12/21qga: Fix latent guest-get-fsinfo error handling bugqga/commands-posix.c+4 -22 replies
13/21memory-device: Fix latent memory pre-plug error handling bugshw/mem/memory-device.c+4 -23 replies
14/21s390x/event-facility: Fix latent realize() error handling bughw/s390x/event-facility.c+4 -21 reply
15/21s390x/cpu_models: Fix latent feature property error handling bugstarget/s390x/cpu_models.c+8 -42 replies
16/21s390/cpu_modules: Fix latent realize() error handling bugstarget/s390x/cpu_models.c+22 -152 replies
17/21s390x: Fix latent query-cpu-model-FOO error handling bugstarget/s390x/cpu_models.c+27 -1612 replies
18/21s390x: Fix latent query-cpu-definitions error handling bugtarget/s390x/cpu_models.c+1 -51 reply
19/21error: Clean up unusual names of Error * variableshw/intc/s390_flic_kvm.c hw/ppc/spapr_pci.c hw/ppc/spapr_pci_nvlink2.c +1 more+26 -261 reply
20/21hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()hw/intc/s390_flic_kvm.c+4 -63 replies
21/21tests-blockjob: Use error_free_or_abort()tests/test-blockjob.c+1 -21 reply

Reviews trailers per patch

20 of 21 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéDavid HildenbrandMichael S. TsirkinIgor MammedovJens FreimannStefan HajnocziKevin WolfCornelia HuckHalil PasicEric BlakeVladimir Sementsov-Ogievskiy
SeriesR-b
1/21R-b
2/21R-b
3/21R-b R-b
4/21R-b
5/21R-b
6/21R-b
7/21R-b
8/21R-b
9/21R-b
10/21R-b R-b
11/21
12/21R-b
13/21R-b
14/21R-b
15/21R-b
16/21R-b
17/21R-b
18/21R-b
19/21R-b
20/21R-b A-b
21/21R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v1 thread

Cover letter [PATCH 00/21] Error handling fixes, may contain 4.2 material

PATCH 2-4 fix crash bugs. Including them would be a no-brainer at -rc0. But we're post -rc3, and even for crash bugs we require a certain likelihood of users getting bitten.

Jens, please assess impact of PATCH 2's crash bug.

Kevin, please do the same for PATCH 3.

Daniel, please do the same for PATCH 4.

The remainder is definitely not 4.2 material.

Cc "Daniel P. Berrangé" <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Christian Borntraeger <[email protected]>
Cc Corey Minyard <[email protected]>
Cc Cornelia Huck <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc Halil Pasic <[email protected]>
Cc Igor Mammedov <[email protected]>
Cc Jens Freimann <[email protected]>
Cc Kevin Wolf <[email protected]>
Cc Michael Roth <[email protected]>
Cc Michael S. Tsirkin <[email protected]>
Cc Nishanth Aravamudan <[email protected]>
Cc Stefan Hajnoczi <[email protected]>

Markus Armbruster (21):
net/virtio: Drop useless n->primary_dev not null checks net/virtio: Fix failover error handling crash bugs block/file-posix: Fix laio_init() error handling crash bug
crypto: Fix certificate file error handling crash bug
crypto: Fix typo in QCryptoTLSSession's <example> comment
io: Fix Error usage in a comment <example>
tests: Clean up initialization of Error *err variables
exec: Fix latent file_ram_alloc() error handling bug hw/acpi: Fix latent legacy CPU plug error handling bug hw/core: Fix latent fit_load_fdt() error handling bug hw/ipmi: Fix latent realize() error handling bugs
qga: Fix latent guest-get-fsinfo error handling bug
memory-device: Fix latent memory pre-plug error handling bugs s390x/event-facility: Fix latent realize() error handling bug s390x/cpu_models: Fix latent feature property error handling bugs s390/cpu_modules: Fix latent realize() error handling bugs
s390x: Fix latent query-cpu-model-FOO error handling bugs
s390x: Fix latent query-cpu-definitions error handling bug
error: Clean up unusual names of Error * variables hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()
tests-blockjob: Use error_free_or_abort()

 include/crypto/tlssession.h         |  2 +-
 include/io/task.h                   |  2 +-
 block/file-posix.c                  |  2 +-
 crypto/tlscredsx509.c               |  2 +-
 exec.c                              |  6 +-
 hw/acpi/cpu_hotplug.c               | 10 +--
 hw/core/loader-fit.c                | 15 ++---
 hw/intc/s390_flic_kvm.c             | 16 +++--
 hw/ipmi/isa_ipmi_bt.c               |  7 ++-
 hw/ipmi/isa_ipmi_kcs.c              |  7 ++-
 hw/ipmi/pci_ipmi_bt.c               |  6 +-
 hw/ipmi/pci_ipmi_kcs.c              |  6 +-
 hw/mem/memory-device.c              |  6 +-
 hw/net/virtio-net.c                 | 27 ++++----
 hw/ppc/spapr_pci.c                  | 16 ++---
 hw/ppc/spapr_pci_nvlink2.c          | 10 +--
 hw/s390x/event-facility.c           |  6 +-
 qga/commands-posix.c                |  6 +-
 target/s390x/cpu_models.c           | 98 +++++++++++++++++------------
 tests/test-blockjob.c               | 15 +++--
 tests/test-qobject-output-visitor.c |  8 +--
 tests/test-string-output-visitor.c  |  4 +-
 22 files changed, 154 insertions(+), 123 deletions(-)
Signature · 1 line
2.21.0