Skip to content

crypto: more self-test improvements

Eric Biggers linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7crypto: aead - move crypto_aead_maxauthsize() to <crypto/aead.h>include/crypto/aead.h include/crypto/internal/aead.h+10 -100 replies
2/7crypto: skcipher - add crypto_skcipher_min_keysize()include/crypto/skcipher.h+6 -00 replies
3/7crypto: testmgr - don't try to decrypt uninitialized bufferscrypto/testmgr.c+16 -40 replies
4/7crypto: testmgr - check skcipher min_keysizecrypto/testmgr.c+9 -00 replies
5/7crypto: testmgr - test setting misaligned keyscrypto/testmgr.c+69 -40 replies
6/7crypto: testmgr - create struct aead_extra_tests_ctxcrypto/testmgr.c+99 -710 replies
7/7crypto: testmgr - generate inauthentic AEAD test vectorscrypto/testmgr.c crypto/testmgr.h+261 -730 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArd Biesheuvel
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] crypto: more self-test improvements

This series makes some more improvements to the crypto self-tests, the largest of which is making the AEAD fuzz tests test inauthentic inputs, i.e. cases where decryption is expected to fail due to the (ciphertext, AAD) pair not being the correct result of an encryption with the key.

It also updates the self-tests to test passing misaligned buffers to the various setkey() functions, and to check that skciphers have the same min_keysize as the corresponding generic implementation.

I haven't seen any test failures from this on x86_64, arm64, or arm32. But as usual I haven't tested drivers for crypto accelerators.

For this series to apply this cleanly, my other series "crypto: skcipher - simplifications due to {,a}blkcipher removal" needs to be applied first, due to a conflict in skcipher.h.

This can also be retrieved from git at
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
tag "crypto-self-tests_2019-12-01".

Eric Biggers (7):
crypto: aead - move crypto_aead_maxauthsize() to <crypto/aead.h>
crypto: skcipher - add crypto_skcipher_min_keysize()
crypto: testmgr - don't try to decrypt uninitialized buffers
crypto: testmgr - check skcipher min_keysize
crypto: testmgr - test setting misaligned keys
crypto: testmgr - create struct aead_extra_tests_ctx
crypto: testmgr - generate inauthentic AEAD test vectors

 crypto/testmgr.c               | 574 +++++++++++++++++++++++++--------
 crypto/testmgr.h               |  14 +-
 include/crypto/aead.h          |  10 +
 include/crypto/internal/aead.h |  10 -
 include/crypto/skcipher.h      |   6 +
 5 files changed, 461 insertions(+), 153 deletions(-)
Signature · 1 line
2.24.0