runner: Don't report subtests that have dynamic subtests
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | runner/resultgen: Extract igt-version field handling to a helperrunner/ | +14 | 0 replies | |
| 2/11 | runner/resultgen: Extract finding begin/end lines for a subtest to a helperrunner/ | +51 | 2 replies | |
| 3/11 | runner/resultgen: Extract finding begin/end pointers for test output to helpersrunner/ | +109 | 0 replies | |
| 4/11 | runner/resultgen: Hoist handling of dynamic subtest output to a helperrunner/ | +78 | 0 replies | |
| 5/11 | runner/resultgen: Extrude dynamic subtest result textsrunner/ | +42 | 0 replies | |
| 6/11 | runner/resultgen: Add support for extra validation hook in find_matches()runner/ | +25 | 0 replies | |
| 7/11 | runner/resultgen: Make subtest result line finding more robustrunner/ | +37 | 0 replies | |
| 8/11 | runner/json_tests: Adapt to dynamic subtest result parsingrunner/ | +10 | 0 replies | |
| 9/11 | runner/resultgen: Don't report subtest result if it has dynamic subtestsrunner/ | +33 | 0 replies | |
| 10/11 | runner/json_tests: Adapt to no longer reporting subtests with dynamic subtestsrunner/ | +9 | 0 replies | |
| 11/11 | runner/json_tests: Add test for parsing dynamic subtests with same namerunner/ runner/ runner/ +9 more | +137 | 0 replies |
Reviews trailers per patch
1 of 11 patches has a Reviewed-by or Acked-by.
| Patch | Arkadiusz Hiler |
|---|---|
| 1/11 | |
| 2/11 | R-b |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t 00/11] runner: Don't report subtests that have dynamic subtests
A feature requested by Martin before full-on conversion to the use of dynamic subtests can begin from cibuglog's perspective.
If we have dynamic subtests to report, don't also report the subtest that contains them.
For example, if we have test "some-test" with subtest "some-subtest" with dynamic subtests "foo" and "bar", we only report igt@some-test@some-subtest@foo and igt@some-test@some-subtest@bar, avoiding igt@some-test@some-subtest altogether.
Parsing dynamic subtests has been changed so that the first dynamic subtest includes all output from the beginning of the subtest so we get the setup messages *somewhere*. Same for the last dynamic subtest, we include all output to the end of the subtest output.
Note that this only changes what gets into results.json; Running the test yourself still gives you all the output.
Petri Latvala (11):
runner/resultgen: Extract igt-version field handling to a helper runner/resultgen: Extract finding begin/end lines for a subtest to a
helper
runner/resultgen: Extract finding begin/end pointers for test output
to helpers
runner/resultgen: Hoist handling of dynamic subtest output to a helper runner/resultgen: Extrude dynamic subtest result texts runner/resultgen: Add support for extra validation hook in
find_matches()
runner/resultgen: Make subtest result line finding more robust runner/json_tests: Adapt to dynamic subtest result parsing runner/resultgen: Don't report subtest result if it has dynamic
subtests
runner/json_tests: Adapt to no longer reporting subtests with dynamic
subtests
runner/json_tests: Add test for parsing dynamic subtests with same
name
.../0/dmesg.txt | 10 + .../0/err.txt | 10 + .../0/journal.txt | 3 + .../0/out.txt | 11 + .../README.txt | 2 + .../endtime.txt | 1 + .../joblist.txt | 1 + .../metadata.txt | 12 + .../reference.json | 84 +++ .../starttime.txt | 1 + .../uname.txt | 1 + .../dynamic-subtests/reference.json | 70 +-- runner/resultgen.c | 528 +++++++++++------- runner/runner_json_tests.c | 1 + 14 files changed, 475 insertions(+), 260 deletions(-) create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/0/dmesg.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/0/err.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/0/journal.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/0/out.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/README.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/endtime.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/joblist.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/metadata.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/reference.json create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/starttime.txt create mode 100644 runner/json_tests_data/dynamic-subtest-name-in-multiple-subtests/uname.txt
Signature · 6 lines
2.19.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev